Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5252)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 132081: Comments added to SSL unit tests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
===================================================================
--- net/url_request/url_request_unittest.cc (revision 18649)
+++ net/url_request/url_request_unittest.cc (working copy)
@@ -219,6 +219,29 @@
};
#if defined(OS_MACOSX)
+// Status 6/19/09:
+//
+// If these tests are enabled on OSX, the first one (HTTPSGetTest)
+// will fail. I didn't track it down explicitly, but did observe that
+// the testserver.py kills itself (e.g. "process_util_posix.cc(84)]
+// Unable to terminate process."). tlslite and testserver.py are hard
+// to debug (redirection of stdout/stderr to a file so you can't see
+// errors; lots of naked "except:" statements, etc), but I did track
+// down an SSL auth failure as one cause of it deciding to die
+// silently.
+//
+// The next test, HTTPSMismatchedTest, will look like it hangs by
+// looping over calls to SSLHandshake() (Security framework call) as
+// called from SSLClientSocketMac::DoHandshake(). Return values are a
+// repeating pattern of -9803 (come back later) and -9812 (cert valid
+// but root not trusted). If you don't have the cert in your keychain
+// as documented on http://dev.chromium.org/developers/testing, the
+// -9812 becomes a -9813 (no root cert). Interestingly, the handshake
+// also appears to be a failure point for other disabled tests, such
+// as (SSLClientSocketTest,Connect) in
+// net/base/ssl_client_socket_unittest.cc.
+//
+// Old comment (not sure if obsolete):
// ssl_client_socket_mac.cc crashes currently in GetSSLInfo
// when called on a connection with an unrecognized certificate
#define MAYBE_HTTPSGetTest DISABLED_HTTPSGetTest
« net/base/ssl_client_socket_unittest.cc ('K') | « net/base/ssl_client_socket_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698