Comments added to SSL unit tests.

net/url_request/url_request_unittest.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_unittest.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
@@ skipping 201 matching lines @@
 
 #ifndef NDEBUG
   DCHECK_EQ(url_request_metrics.object_count, 0);
 #endif
 }
 
 class HTTPSRequestTest : public testing::Test {
 };
 
 #if defined(OS_MACOSX)
+// Status 6/19/09:
+//
+// If these tests are enabled on OSX, the first one (HTTPSGetTest)
+// will fail.  I didn't track it down explicitly, but did observe that
+// the testserver.py kills itself (e.g. "process_util_posix.cc(84)]
+// Unable to terminate process.").  tlslite and testserver.py are hard
+// to debug (redirection of stdout/stderr to a file so you can't see
+// errors; lots of naked "except:" statements, etc), but I did track
+// down an SSL auth failure as one cause of it deciding to die
+// silently.
+//
+// The next test, HTTPSMismatchedTest, will look like it hangs by
+// looping over calls to SSLHandshake() (Security framework call) as
+// called from SSLClientSocketMac::DoHandshake().  Return values are a
+// repeating pattern of -9803 (come back later) and -9812 (cert valid
+// but root not trusted).  If you don't have the cert in your keychain
+// as documented on http://dev.chromium.org/developers/testing, the
+// -9812 becomes a -9813 (no root cert).  Interestingly, the handshake
+// also appears to be a failure point for other disabled tests, such
+// as (SSLClientSocketTest,Connect) in
+// net/base/ssl_client_socket_unittest.cc.
+//
+// Old comment (not sure if obsolete):
 // ssl_client_socket_mac.cc crashes currently in GetSSLInfo
 // when called on a connection with an unrecognized certificate
 #define MAYBE_HTTPSGetTest        DISABLED_HTTPSGetTest
 #define MAYBE_HTTPSMismatchedTest DISABLED_HTTPSMismatchedTest
 #define MAYBE_HTTPSExpiredTest    DISABLED_HTTPSExpiredTest
 #else
 #define MAYBE_HTTPSGetTest        HTTPSGetTest
 #define MAYBE_HTTPSMismatchedTest HTTPSMismatchedTest
 #define MAYBE_HTTPSExpiredTest    HTTPSExpiredTest
 #endif
@@ skipping 1567 matching lines @@
 
     int64 file_size = 0;
     file_util::GetFileSize(app_path, &file_size);
 
     EXPECT_TRUE(!r.is_pending());
     EXPECT_EQ(1, d.response_started_count());
     EXPECT_FALSE(d.received_data_before_response());
     EXPECT_EQ(d.bytes_received(), 0);
   }
 }