Source/core/html/FormAssociatedElement.cpp - Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/FormAssociatedElement.cpp

Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: revert unrelated unit test addition Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/FormAssociatedElement.cpp

diff --git a/Source/core/html/FormAssociatedElement.cpp b/Source/core/html/FormAssociatedElement.cpp

index ffb7151311a819c639d716cc4bc03bb9b2f45630..f3846ca5f1d1ce5786b11b5bc221dc8be092c739 100644

--- a/Source/core/html/FormAssociatedElement.cpp

+++ b/Source/core/html/FormAssociatedElement.cpp

@@ -162,11 +162,7 @@ void FormAssociatedElement::setForm(HTMLFormElement* newForm)

#endif

m_form->associate(*this);

} else {

-#if ENABLE(OILPAN)

m_form = nullptr;

-#else

- m_form = WeakPtr<HTMLFormElement>();

-#endif

}

didChangeForm();

}