Source/core/html/FormAssociatedElement.h - Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/FormAssociatedElement.h

Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: revert unrelated unit test addition Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/FormAssociatedElement.h

diff --git a/Source/core/html/FormAssociatedElement.h b/Source/core/html/FormAssociatedElement.h

index 34f1c103b314582cb61cf775910b7c742a641161..b27de42ed8a7443ff062edf53bbdc27e31c929e0 100644

--- a/Source/core/html/FormAssociatedElement.h

+++ b/Source/core/html/FormAssociatedElement.h

@@ -126,11 +126,7 @@ private:

void resetFormAttributeTargetObserver();

OwnPtrWillBeMember<FormAttributeTargetObserver> m_formAttributeTargetObserver;

-#if ENABLE(OILPAN)

- Member<HTMLFormElement> m_form;

-#else

- WeakPtr<HTMLFormElement> m_form;

-#endif

+ WeakPtrWillBeMember<HTMLFormElement> m_form;

OwnPtrWillBeMember<ValidityState> m_validityState;

String m_customValidationMessage;

// Non-Oilpan: Even if m_formWasSetByParser is true, m_form can be null