Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: Source/core/html/FormAssociatedElement.cpp

Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: revert unrelated unit test addition Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 if (m_form) 155 if (m_form)
156 m_form->disassociate(*this); 156 m_form->disassociate(*this);
157 if (newForm) { 157 if (newForm) {
158 #if ENABLE(OILPAN) 158 #if ENABLE(OILPAN)
159 m_form = newForm; 159 m_form = newForm;
160 #else 160 #else
161 m_form = newForm->createWeakPtr(); 161 m_form = newForm->createWeakPtr();
162 #endif 162 #endif
163 m_form->associate(*this); 163 m_form->associate(*this);
164 } else { 164 } else {
165 #if ENABLE(OILPAN)
166 m_form = nullptr; 165 m_form = nullptr;
167 #else
168 m_form = WeakPtr<HTMLFormElement>();
169 #endif
170 } 166 }
171 didChangeForm(); 167 didChangeForm();
172 } 168 }
173 169
174 void FormAssociatedElement::willChangeForm() 170 void FormAssociatedElement::willChangeForm()
175 { 171 {
176 } 172 }
177 173
178 void FormAssociatedElement::didChangeForm() 174 void FormAssociatedElement::didChangeForm()
179 { 175 {
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 visitor->trace(m_element); 349 visitor->trace(m_element);
354 IdTargetObserver::trace(visitor); 350 IdTargetObserver::trace(visitor);
355 } 351 }
356 352
357 void FormAttributeTargetObserver::idTargetChanged() 353 void FormAttributeTargetObserver::idTargetChanged()
358 { 354 {
359 m_element->formAttributeTargetChanged(); 355 m_element->formAttributeTargetChanged();
360 } 356 }
361 357
362 } // namespace blink 358 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698