Source/core/html/HTMLImageElement.h - Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLImageElement.h

Issue 1320563003: Oilpan: avoid using WeakPtr<> for heap residing objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: revert unrelated unit test addition Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLImageElement.h

diff --git a/Source/core/html/HTMLImageElement.h b/Source/core/html/HTMLImageElement.h

index 4cbb0d298e857894b669fe60cb5ee13e3849dd66..1d5dd11e709e87368df5cfff71e67a154ba56293 100644

--- a/Source/core/html/HTMLImageElement.h

+++ b/Source/core/html/HTMLImageElement.h

@@ -157,11 +157,7 @@ private:

OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader;

RefPtrWillBeMember<ViewportChangeListener> m_listener;

-#if ENABLE(OILPAN)

- Member<HTMLFormElement> m_form;

-#else

- WeakPtr<HTMLFormElement> m_form;

-#endif

+ WeakPtrWillBeMember<HTMLFormElement> m_form;

AtomicString m_bestFitImageURL;

float m_imageDevicePixelRatio;

unsigned m_formWasSetByParser : 1;