Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 1319783006: Ship Notifications requireInteraction by default (blink side) (Closed)

Created:
5 years, 3 months ago by johnme
Modified:
5 years, 3 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@requireinteraction2
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ship Notifications requireInteraction by default (blink side) Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Yr_sEG3cnWw/97sk8JXCAwAJ This is a 2-sided patch: 1. this patch 2. https://codereview.chromium.org/1320173002 BUG=507751 Committed: https://crrev.com/a147ef26ab4490256e5aa7f422d350a245d06398 git-svn-id: svn://svn.chromium.org/blink/trunk@202220 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Update virtual/stable webexposed expectations #

Messages

Total messages: 14 (5 generated)
johnme
5 years, 3 months ago (2015-08-28 18:10:49 UTC) #2
Peter Beverloo
You'll need to update the stable interface listing layout tests, otherwise this looks fine. I'll ...
5 years, 3 months ago (2015-09-01 11:25:10 UTC) #3
Peter Beverloo
On 2015/09/01 11:25:10, Peter Beverloo wrote: > You'll need to update the stable interface listing ...
5 years, 3 months ago (2015-09-08 09:40:48 UTC) #4
Peter Beverloo
Is something blocking this patch? The sooner people can start preparing for new default behaviour ...
5 years, 3 months ago (2015-09-14 13:56:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319783006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319783006/20001
5 years, 3 months ago (2015-09-14 16:15:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/54046)
5 years, 3 months ago (2015-09-14 16:30:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319783006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319783006/20001
5 years, 3 months ago (2015-09-14 18:07:45 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202220
5 years, 3 months ago (2015-09-14 18:44:02 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:35:05 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a147ef26ab4490256e5aa7f422d350a245d06398

Powered by Google App Engine
This is Rietveld 408576698