Source/modules/notifications/NotificationOptions.idl - Issue 1319783006: Ship Notifications requireInteraction by default (blink side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/NotificationOptions.idl

Issue 1319783006: Ship Notifications requireInteraction by default (blink side) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@requireinteraction2

Patch Set: Update virtual/stable webexposed expectations Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/notifications/NotificationOptions.idl

diff --git a/Source/modules/notifications/NotificationOptions.idl b/Source/modules/notifications/NotificationOptions.idl

index b1f91a6164d32c9ccf85528132938f9e786cc655..3047c29604b980fc19f3291d53fca0654c859564 100644

--- a/Source/modules/notifications/NotificationOptions.idl

+++ b/Source/modules/notifications/NotificationOptions.idl

@@ -19,7 +19,7 @@ dictionary NotificationOptions {

// TODO(sh919.park): vibrate should be ([Clamp] unsigned long or sequence<unsigned long>)

(unsigned long or sequence<unsigned long>) vibrate;

boolean silent = false;

- [RuntimeEnabled=NotificationExperimental] boolean requireInteraction = false;

+ boolean requireInteraction = false;

any data = null;

[RuntimeEnabled=NotificationExperimental] sequence<NotificationAction> actions = [];

};

« no previous file with comments | « Source/modules/notifications/Notification.idl ('k') | no next file » | no next file with comments »