Source/modules/notifications/Notification.idl - Issue 1319783006: Ship Notifications requireInteraction by default (blink side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.idl

Issue 1319783006: Ship Notifications requireInteraction by default (blink side) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@requireinteraction2

Patch Set: Update virtual/stable webexposed expectations Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt ('k') | Source/modules/notifications/NotificationOptions.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/Notification.idl

diff --git a/Source/modules/notifications/Notification.idl b/Source/modules/notifications/Notification.idl

index 4d92e1768e9b89a27374dd23910ed2e4b9603066..8d78f7f5b590ad127f32bf215764a0fd22d84397 100644

--- a/Source/modules/notifications/Notification.idl

+++ b/Source/modules/notifications/Notification.idl

@@ -70,7 +70,7 @@ enum NotificationPermission {

[RuntimeEnabled=NotificationExperimental] readonly attribute sequence<unsigned long>? vibrate;

readonly attribute boolean silent;

- [RuntimeEnabled=NotificationExperimental] readonly attribute boolean requireInteraction;

+ readonly attribute boolean requireInteraction;

[CallWith=ScriptState, SameObject] readonly attribute any data;

// TODO(johnme): The spec requires a FrozenArray, but sequence seems to behave like one already?! https://crbug.com/515920