Change first() and second() in CSSPairValue to return const references

Change first() and second() in CSSPairValue to return const references

Change the first() and second() methods in CSSPairValue to return const
references instead of pointers, since CSSPairValue never stores null
objects.

BUG=526586
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201532

[sashab, 2015-08-31 05:01:34]

sashab@chromium.org changed reviewers:
+ timloh@chromium.org

[alancutter (OOO until 2018), 2015-08-31 05:49:20]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2015-08-31 05:49:21]

lgtm with nits.

https://codereview.chromium.org/1318543010/diff/20001/Source/core/css/CSSValu...
File Source/core/css/CSSValuePair.h (right):

https://codereview.chromium.org/1318543010/diff/20001/Source/core/css/CSSValu...
Source/core/css/CSSValuePair.h:51: CSSValue& second() { return *m_second; }
Can these be trivially removed? If they can be removed with further simple
patches please add a TODO.

https://codereview.chromium.org/1318543010/diff/20001/Source/core/css/CSSValu...
Source/core/css/CSSValuePair.h:53: const CSSValue& second() const { return
*m_second; }
Now that these are references we should assert them in the constructor.

[sashab, 2015-09-01 04:54:41]

https://codereview.chromium.org/1318543010/diff/20001/Source/core/css/CSSValu...
File Source/core/css/CSSValuePair.h (right):

https://codereview.chromium.org/1318543010/diff/20001/Source/core/css/CSSValu...
Source/core/css/CSSValuePair.h:51: CSSValue& second() { return *m_second; }
On 2015/08/31 05:49:21, alancutter wrote:
> Can these be trivially removed? If they can be removed with further simple
> patches please add a TODO.

It's not *super* easy to remove them... Lots of places don't use const
cssvalues, even though they probably should. But added a comment because you're
right, they shouldn't be here :)

https://codereview.chromium.org/1318543010/diff/20001/Source/core/css/CSSValu...
Source/core/css/CSSValuePair.h:53: const CSSValue& second() const { return
*m_second; }
On 2015/08/31 05:49:21, alancutter wrote:
> Now that these are references we should assert them in the constructor.

Thanks, done.

[Timothy Loh, 2015-09-01 06:35:18]

lgtm

[sashab, 2015-09-01 06:48:23]

The CQ bit was checked by sashab@chromium.org

[sashab, 2015-09-01 06:48:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1318543010/#ps40001
(title: "Review feedback")

[commit-bot: I haz the power, 2015-09-01 06:48:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1318543010/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1318543010/40001

[commit-bot: I haz the power, 2015-09-01 07:59:05]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201532