Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 1318543010: Change first() and second() in CSSPairValue to return const references (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSValuePair.h ('k') | Source/core/css/resolver/CSSToStyleMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 5c88c54ae81208312709032cb2c521cefb9ec113..d678218f2787281761258d912444ba0900a00df5 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -2584,10 +2584,10 @@ void CSSPropertyParser::parse3ValuesFillPosition(CSSParserValueList* valueList,
value1.swap(value2);
#if ENABLE(ASSERT)
- const CSSValuePair* first = toCSSValuePair(value1.get());
- const CSSValuePair* second = toCSSValuePair(value2.get());
- ident1 = toCSSPrimitiveValue(first->first())->getValueID();
- ident2 = toCSSPrimitiveValue(second->first())->getValueID();
+ const CSSValuePair& first = toCSSValuePair(*value1);
+ const CSSValuePair& second = toCSSValuePair(*value2);
+ ident1 = toCSSPrimitiveValue(first.first()).getValueID();
+ ident2 = toCSSPrimitiveValue(second.first()).getValueID();
ASSERT(ident1 == CSSValueLeft || ident1 == CSSValueRight);
ASSERT(ident2 == CSSValueBottom || ident2 == CSSValueTop);
#endif
« no previous file with comments | « Source/core/css/CSSValuePair.h ('k') | Source/core/css/resolver/CSSToStyleMap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698