Change first() and second() in CSSPairValue to return const references

Source/core/css/CSSValuePair.h

 /*
  * (C) 1999-2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 29 matching lines @@
         IdenticalValuesPolicy identicalValuesPolicy)
     {
         return adoptRefWillBeNoop(new CSSValuePair(first, second, identicalValuesPolicy));
     }
 
     static PassRefPtrWillBeRawPtr<CSSValuePair> create(const LengthSize& lengthSize, const ComputedStyle& style)
     {
         return adoptRefWillBeNoop(new CSSValuePair(CSSPrimitiveValue::create(lengthSize.width(), style.effectiveZoom()), CSSPrimitiveValue::create(lengthSize.height(), style.effectiveZoom()), KeepIdenticalValues));
     }
 
-    CSSValue* first() const { return m_first.get(); }
-    CSSValue* second() const { return m_second.get(); }
+    CSSValue& first() { return *m_first; }
+    CSSValue& second() { return *m_second; }

[alancutter (OOO until 2018), 2015/08/31 05:49:21]

Can these be trivially removed? If they can be removed with further simple
patches please add a TODO.

[sashab, 2015/09/01 04:54:41]

It's not *super* easy to remove them... Lots of places don't use const
cssvalues, even though they probably should. But added a comment because you're
right, they shouldn't be here :)

+    const CSSValue& first() const { return *m_first; }
+    const CSSValue& second() const { return *m_second; }

[alancutter (OOO until 2018), 2015/08/31 05:49:21]

Now that these are references we should assert them in the constructor.

[sashab, 2015/09/01 04:54:41]

Thanks, done.

 
     String customCSSText() const
     {
         String first = m_first->cssText();
         String second = m_second->cssText();
         if (m_identicalValuesPolicy == DropIdenticalValues && first == second)
             return first;
         return first + ' ' + second;
     }
 
@@ skipping 16 matching lines @@
     RefPtrWillBeMember<CSSValue> m_first;
     RefPtrWillBeMember<CSSValue> m_second;
     IdenticalValuesPolicy m_identicalValuesPolicy;
 };
 
 DEFINE_CSS_VALUE_TYPE_CASTS(CSSValuePair, isValuePair());
 
 } // namespace
 
 #endif // CSSValuePair_h