Source/core/animation/DeferredLegacyStyleInterpolation.cpp - Issue 1318543010: Change first() and second() in CSSPairValue to return const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/DeferredLegacyStyleInterpolation.cpp

Issue 1318543010: Change first() and second() in CSSPairValue to return const references (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Review feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/DeferredLegacyStyleInterpolation.cpp

diff --git a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp

index 4a1b60fca0f9ea44600589c5573f3eb541f89743..a6b0cfd28fa2e60e8f2be29b3a5d62646e05b417 100644

--- a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp

+++ b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp

@@ -130,8 +130,8 @@ bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C

bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSValuePair& pair)

{

- return interpolationRequiresStyleResolve(*pair.first())

- || interpolationRequiresStyleResolve(*pair.second());

+ return interpolationRequiresStyleResolve(pair.first())

+ || interpolationRequiresStyleResolve(pair.second());

}

bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const CSSBasicShape& shape)