Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318043002: Native context: do not put public symbols and flags on the js builtins object. (Closed)

Created:
5 years, 3 months ago by Yang
Modified:
5 years, 3 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Native context: do not put public symbols and flags on the js builtins object. R=cbruni@chromium.org,mlippautz@chromium.org Committed: https://crrev.com/cde62571a4ab9d9a172dda4a2238888ded6a8c96 Cr-Commit-Position: refs/heads/master@{#30438}

Patch Set 1 #

Patch Set 2 : fix and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -226 lines) Patch
M src/array.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/array-iterator.js View 1 3 chunks +10 lines, -8 lines 0 comments Download
M src/arraybuffer.js View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/bootstrapper.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 4 chunks +47 lines, -64 lines 0 comments Download
M src/collection.js View 1 3 chunks +4 lines, -3 lines 0 comments Download
M src/collection-iterator.js View 1 5 chunks +6 lines, -4 lines 0 comments Download
M src/date.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/debug/mirrors.js View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/factory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/generator.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/harmony-array.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/harmony-atomics.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/harmony-concat-spreadable.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/harmony-reflect.js View 1 2 chunks +4 lines, -5 lines 0 comments Download
M src/harmony-sharedarraybuffer.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/harmony-simd.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/harmony-tostring.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 4 chunks +10 lines, -15 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/i18n.js View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/iterator-prototype.js View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/json.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/math.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/messages.js View 1 3 chunks +12 lines, -13 lines 0 comments Download
M src/prologue.js View 1 8 chunks +15 lines, -14 lines 0 comments Download
M src/promise.js View 1 2 chunks +8 lines, -7 lines 0 comments Download
M src/regexp.js View 1 7 chunks +13 lines, -8 lines 0 comments Download
M src/runtime.js View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 1 chunk +17 lines, -4 lines 0 comments Download
M src/string.js View 3 chunks +3 lines, -1 line 0 comments Download
M src/string-iterator.js View 1 2 chunks +7 lines, -5 lines 0 comments Download
M src/symbol.js View 1 5 chunks +25 lines, -23 lines 0 comments Download
M src/typedarray.js View 1 5 chunks +6 lines, -4 lines 0 comments Download
M src/v8natives.js View 1 4 chunks +9 lines, -10 lines 0 comments Download
M src/weak-collection.js View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
5 years, 3 months ago (2015-08-27 13:23:04 UTC) #1
Camillo Bruni
lgtm
5 years, 3 months ago (2015-08-27 13:53:12 UTC) #2
Michael Lippautz
lgtm
5 years, 3 months ago (2015-08-27 13:54:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318043002/1
5 years, 3 months ago (2015-08-27 14:02:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/9157)
5 years, 3 months ago (2015-08-27 14:12:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318043002/20001
5 years, 3 months ago (2015-08-28 09:49:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-28 10:22:34 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 10:22:47 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cde62571a4ab9d9a172dda4a2238888ded6a8c96
Cr-Commit-Position: refs/heads/master@{#30438}

Powered by Google App Engine
This is Rietveld 408576698