src/harmony-array.js - Issue 1318043002: Native context: do not put public symbols and flags on the js builtins object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/harmony-array.js

Issue 1318043002: Native context: do not put public symbols and flags on the js builtins object. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix and rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/harmony-array.js

diff --git a/src/harmony-array.js b/src/harmony-array.js

index 49176460ad2ee42fe38dcc4d6ef18d20e3f4e06e..885950b8ea0a324afd23b7a877499a32a8a191f3 100644

--- a/src/harmony-array.js

+++ b/src/harmony-array.js

@@ -14,7 +14,7 @@

var GetIterator;

var GetMethod;

var GlobalArray = global.Array;

-var GlobalSymbol = global.Symbol;

+var iteratorSymbol = utils.ImportNow("iterator_symbol");

var MathMax;

var MathMin;

var ObjectIsFrozen;

@@ -221,7 +221,7 @@ function ArrayFrom(arrayLike, mapfn, receiver) {

}

- var iterable = GetMethod(items, symbolIterator);

+ var iterable = GetMethod(items, iteratorSymbol);

var k;

var result;

var mappedValue;

« no previous file with comments | « src/generator.js ('k') | src/harmony-atomics.js » ('j') | no next file with comments »