src/array.js - Issue 1318043002: Native context: do not put public symbols and flags on the js builtins object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/array.js

Issue 1318043002: Native context: do not put public symbols and flags on the js builtins object. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix and rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/array.js

diff --git a/src/array.js b/src/array.js

index af3dbd701ebac2f756dde8ff379af2c5efc9370c..84c76620326f2973b270efd634594bc8e60e5df2 100644

--- a/src/array.js

+++ b/src/array.js

@@ -22,6 +22,7 @@ var ObjectIsSealed;

var ObjectToString;

var ToNumber;

var ToString;

+var unscopablesSymbol = utils.ImportNow("unscopables_symbol");

utils.Import(function(from) {

Delete = from.Delete;

@@ -1610,7 +1611,7 @@ var unscopables = {

keys: true,

};

-%AddNamedProperty(GlobalArray.prototype, symbolUnscopables, unscopables,

+%AddNamedProperty(GlobalArray.prototype, unscopablesSymbol, unscopables,

DONT_ENUM | READ_ONLY);

// Set up non-enumerable functions on the Array object.

« no previous file with comments | « no previous file | src/array-iterator.js » ('j') | no next file with comments »