src/math.js - Issue 1318043002: Native context: do not put public symbols and flags on the js builtins object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/math.js

Issue 1318043002: Native context: do not put public symbols and flags on the js builtins object. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix and rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/math.js

diff --git a/src/math.js b/src/math.js

index 51f4d445c7fc780c780cb5e0d947c640aa40928a..05eb9e46d7ed581a9659edd94f598b41f78441e7 100644

--- a/src/math.js

+++ b/src/math.js

@@ -15,6 +15,7 @@ var rngstate; // Initialized to a Uint32Array during genesis.

var GlobalMath = global.Math;

var GlobalObject = global.Object;

var InternalArray = utils.InternalArray;

+var toStringTagSymbol = utils.ImportNow("to_string_tag_symbol");

//-------------------------------------------------------------------

@@ -288,7 +289,7 @@ function CubeRoot(x) {

// -------------------------------------------------------------------

-%AddNamedProperty(GlobalMath, symbolToStringTag, "Math", READ_ONLY | DONT_ENUM);

+%AddNamedProperty(GlobalMath, toStringTagSymbol, "Math", READ_ONLY | DONT_ENUM);

// Set up math constants.

utils.InstallConstants(GlobalMath, [

« no previous file with comments | « src/json.js ('k') | src/messages.js » ('j') | no next file with comments »