Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1317813003: Revert of [Background Sync] Allow sync manager access from uncontrolled clients (Closed)

Created:
5 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, tim+watch_chromium.org, viettrungluu+watch_chromium.org, qsr+mojo_chromium.org, zea+watch_chromium.org, Aaron Boodman, maxbogue+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Background Sync] Allow sync manager access from uncontrolled clients (patchset #2 id:20001 of https://codereview.chromium.org/1316743002/ ) Reason for revert: This is breaking background_sync LayoutTests: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/53395 I guess part 3 would have fixed that but it doesn't seem to be ready to land. Original issue's description: > [Background Sync] Allow sync manager access from uncontrolled clients > > This patch removes the requirement for the caller of a BackgroundSync > manager method to be either a service worker or a controlled client. > Now, uncontrolled clients are also able to access the manager, and Blink > informs the browser whether a registration request came from a Service > Worker or not. (Service Workers are still required to have at least one > active window client in order to register sync events; this is enforced > in the browser). > > This is part 2 of a three-part blink-chromium-blink dance. > Part 1: https://codereview.chromium.org/1309393003 > Part 2: https://codereview.chromium.org/1316743002 (this patch) > Part 3: https://codereview.chromium.org/1314453003 > > BUG=518884 > > Committed: https://crrev.com/d7c429ff6d306e720d6b0e7b64be25c8efad82d8 > Cr-Commit-Position: refs/heads/master@{#346459} TBR=jkarlin@chromium.org,tsepez@chromium.org,iclelland@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518884 Committed: https://crrev.com/9a31c59a3d7e2b90a8bf97b3432fd1a2fdc1820e Cr-Commit-Position: refs/heads/master@{#346613}

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
mlamouri (slow - plz ping)
Created Revert of [Background Sync] Allow sync manager access from uncontrolled clients
5 years, 3 months ago (2015-09-01 10:12:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317813003/1
5 years, 3 months ago (2015-09-01 10:12:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 10:13:05 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 10:13:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a31c59a3d7e2b90a8bf97b3432fd1a2fdc1820e
Cr-Commit-Position: refs/heads/master@{#346613}

Powered by Google App Engine
This is Rietveld 408576698