content/child/background_sync/background_sync_provider.cc - Issue 1317813003: Revert of [Background Sync] Allow sync manager access from uncontrolled clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/background_sync/background_sync_provider.cc

Issue 1317813003: Revert of [Background Sync] Allow sync manager access from uncontrolled clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/background_sync/background_sync_provider.h ('k') | content/child/background_sync/background_sync_provider_thread_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/background_sync/background_sync_provider.cc

diff --git a/content/child/background_sync/background_sync_provider.cc b/content/child/background_sync/background_sync_provider.cc

index 750059e2c13d2ed057162258077ba4a385b179f5..bbe67d505b2797bf8eb19abbd3ae0c74b28d689b 100644

--- a/content/child/background_sync/background_sync_provider.cc

+++ b/content/child/background_sync/background_sync_provider.cc

@@ -40,7 +40,6 @@

void BackgroundSyncProvider::registerBackgroundSync(

const blink::WebSyncRegistration* options,

blink::WebServiceWorkerRegistration* service_worker_registration,

- bool requested_from_service_worker,

blink::WebSyncRegistrationCallbacks* callbacks) {

DCHECK(options);

DCHECK(service_worker_registration);

@@ -54,7 +53,7 @@

// will wipe its callbacks) before 'this' is deleted.

GetBackgroundSyncServicePtr()->Register(

mojo::ConvertTo<SyncRegistrationPtr>(*(optionsPtr.get())),

- service_worker_registration_id, requested_from_service_worker,

+ service_worker_registration_id,

base::Bind(&BackgroundSyncProvider::RegisterCallback,

base::Unretained(this), base::Passed(callbacksPtr.Pass())));

}