Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1317803002: Convert wtf_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 4 months ago by joelo
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, jsbell
Base URL:
https://chromium.googlesource.com/chromium/src.git@swarm_blink_platform_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert wtf_unittests to run exclusively on Swarming 0 configs already ran on Swarming 43 used to run locally and were converted: - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.webkit.json: WebKit Linux - chromium.webkit.json: WebKit Linux (dbg) - chromium.webkit.json: WebKit Linux 32 - chromium.webkit.json: WebKit Linux Leak - chromium.webkit.json: WebKit Linux Oilpan - chromium.webkit.json: WebKit Linux Oilpan (dbg) - chromium.webkit.json: WebKit Linux Oilpan Leak - chromium.webkit.json: WebKit Linux Trusty - chromium.webkit.json: WebKit Mac Oilpan - chromium.webkit.json: WebKit Mac Oilpan (dbg) - chromium.webkit.json: WebKit Mac10.10 - chromium.webkit.json: WebKit Mac10.6 - chromium.webkit.json: WebKit Mac10.6 (dbg) - chromium.webkit.json: WebKit Mac10.7 - chromium.webkit.json: WebKit Mac10.7 (dbg) - chromium.webkit.json: WebKit Mac10.8 - chromium.webkit.json: WebKit Mac10.9 - chromium.webkit.json: WebKit Mac10.9 (retina) - chromium.webkit.json: WebKit Win Oilpan - chromium.webkit.json: WebKit Win Oilpan (dbg) - chromium.webkit.json: WebKit Win x64 Builder - chromium.webkit.json: WebKit Win x64 Builder (dbg) - chromium.webkit.json: WebKit Win10 - chromium.webkit.json: WebKit Win7 - chromium.webkit.json: WebKit Win7 (dbg) - chromium.webkit.json: WebKit XP Ran: ./manage.py --convert wtf_unittests R=maruel@chromium.org,dpranke@chromium.org BUG=98637, 524758 Committed: https://crrev.com/5a612be97cfe101c64d072d39139f2952762c23b Cr-Commit-Position: refs/heads/master@{#348829}

Patch Set 1 #

Patch Set 2 : add run target to gn_migration.gypi #

Patch Set 3 : merge changes and rerun manage.py #

Patch Set 4 : merge upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -0 lines) Patch
M build/gn_migration.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 17 chunks +51 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 1 2 26 chunks +78 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
joelo
ptal :) isolate file added in https://codereview.chromium.org/1316763004/
5 years, 4 months ago (2015-08-26 01:39:50 UTC) #2
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-26 01:44:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317803002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317803002/60001
5 years, 3 months ago (2015-09-15 01:38:34 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-15 03:08:26 UTC) #7
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/5a612be97cfe101c64d072d39139f2952762c23b Cr-Commit-Position: refs/heads/master@{#348829}
5 years, 3 months ago (2015-09-15 03:09:08 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:42:12 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5a612be97cfe101c64d072d39139f2952762c23b
Cr-Commit-Position: refs/heads/master@{#348829}

Powered by Google App Engine
This is Rietveld 408576698