Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1316763004: Add isolate/swarming support for some Blink test targets. (Closed)

Created:
5 years, 4 months ago by joelo
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, jsbell
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add isolate/swarming support for some Blink test targets. The following targets are now supported: - blink_heap_unittests - blink_platform_unittests - wtf_unittests BUG=524758 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201437

Patch Set 1 #

Total comments: 6

Patch Set 2 : don't bother with xvfb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -0 lines) Patch
A Source/platform/blink_heap_unittests.isolate View 1 1 chunk +28 lines, -0 lines 0 comments Download
M Source/platform/blink_platform_tests.gyp View 1 chunk +30 lines, -0 lines 0 comments Download
A Source/platform/blink_platform_unittests.isolate View 1 1 chunk +27 lines, -0 lines 0 comments Download
M Source/wtf/wtf_tests.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
A Source/wtf/wtf_unittests.isolate View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joelo
ptal :)
5 years, 4 months ago (2015-08-26 00:07:48 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1316763004/diff/1/Source/platform/blink_heap_unittests.isolate File Source/platform/blink_heap_unittests.isolate (right): https://codereview.chromium.org/1316763004/diff/1/Source/platform/blink_heap_unittests.isolate#newcode6 Source/platform/blink_heap_unittests.isolate:6: ['use_x11==0', { You shouldn't need both of these blocks; ...
5 years, 4 months ago (2015-08-26 00:54:17 UTC) #3
joelo
ptal https://codereview.chromium.org/1316763004/diff/1/Source/platform/blink_heap_unittests.isolate File Source/platform/blink_heap_unittests.isolate (right): https://codereview.chromium.org/1316763004/diff/1/Source/platform/blink_heap_unittests.isolate#newcode6 Source/platform/blink_heap_unittests.isolate:6: ['use_x11==0', { On 2015/08/26 00:54:16, Dirk Pranke wrote: ...
5 years, 4 months ago (2015-08-26 01:31:49 UTC) #4
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-26 01:32:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316763004/20001
5 years, 3 months ago (2015-08-28 21:50:27 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 23:19:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201437

Powered by Google App Engine
This is Rietveld 408576698