Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1341903002: Convert webkit_unit_tests to run exclusively on Swarming (Closed)

Created:
5 years, 3 months ago by joelo
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@swarm_wtf_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert webkit_unit_tests to run exclusively on Swarming 0 configs already ran on Swarming 43 used to run locally and were converted: - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.webkit.json: WebKit Linux - chromium.webkit.json: WebKit Linux (dbg) - chromium.webkit.json: WebKit Linux 32 - chromium.webkit.json: WebKit Linux Leak - chromium.webkit.json: WebKit Linux Oilpan - chromium.webkit.json: WebKit Linux Oilpan (dbg) - chromium.webkit.json: WebKit Linux Oilpan Leak - chromium.webkit.json: WebKit Linux Trusty - chromium.webkit.json: WebKit Mac Oilpan - chromium.webkit.json: WebKit Mac Oilpan (dbg) - chromium.webkit.json: WebKit Mac10.10 - chromium.webkit.json: WebKit Mac10.6 - chromium.webkit.json: WebKit Mac10.6 (dbg) - chromium.webkit.json: WebKit Mac10.7 - chromium.webkit.json: WebKit Mac10.7 (dbg) - chromium.webkit.json: WebKit Mac10.8 - chromium.webkit.json: WebKit Mac10.9 - chromium.webkit.json: WebKit Mac10.9 (retina) - chromium.webkit.json: WebKit Win Oilpan - chromium.webkit.json: WebKit Win Oilpan (dbg) - chromium.webkit.json: WebKit Win x64 Builder - chromium.webkit.json: WebKit Win x64 Builder (dbg) - chromium.webkit.json: WebKit Win10 - chromium.webkit.json: WebKit Win7 - chromium.webkit.json: WebKit Win7 (dbg) - chromium.webkit.json: WebKit XP Ran: ./manage.py --convert webkit_unit_tests R=maruel@chromium.org,dpranke@chromium.org BUG=98637, 524758 Committed: https://crrev.com/40eeb7ab654466217dcbd444bd7d853cba8b3348 Cr-Commit-Position: refs/heads/master@{#348834}

Patch Set 1 #

Patch Set 2 : merge upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -0 lines) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 17 chunks +51 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 26 chunks +78 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (4 generated)
joelo
maruel@ dpranke@: ptal :)
5 years, 3 months ago (2015-09-14 21:49:29 UTC) #1
Dirk Pranke
rubber-stamp lgtm.
5 years, 3 months ago (2015-09-14 22:19:17 UTC) #2
M-A Ruel
I guess the isolate was already good, cool. lgtm
5 years, 3 months ago (2015-09-15 00:18:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341903002/20001
5 years, 3 months ago (2015-09-15 00:19:09 UTC) #5
commit-bot: I haz the power
Failed to apply patch for build/gn_migration.gypi: While running git apply --index -3 -p1; error: patch ...
5 years, 3 months ago (2015-09-15 01:33:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341903002/20001
5 years, 3 months ago (2015-09-15 03:33:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 03:39:12 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/40eeb7ab654466217dcbd444bd7d853cba8b3348 Cr-Commit-Position: refs/heads/master@{#348834}
5 years, 3 months ago (2015-09-15 03:40:34 UTC) #12
kochi
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1345713002/ by kochi@chromium.org. ...
5 years, 3 months ago (2015-09-15 06:26:17 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:42:28 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40eeb7ab654466217dcbd444bd7d853cba8b3348
Cr-Commit-Position: refs/heads/master@{#348834}

Powered by Google App Engine
This is Rietveld 408576698