Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 1311253006: Convert blink_platform_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 3 months ago by joelo
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, jsbell
Base URL:
https://chromium.googlesource.com/chromium/src.git@swarm_blink_heap_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert blink_platform_unittests to run exclusively on Swarming 0 configs already ran on Swarming 43 used to run locally and were converted: - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.webkit.json: WebKit Linux - chromium.webkit.json: WebKit Linux (dbg) - chromium.webkit.json: WebKit Linux 32 - chromium.webkit.json: WebKit Linux Leak - chromium.webkit.json: WebKit Linux Oilpan - chromium.webkit.json: WebKit Linux Oilpan (dbg) - chromium.webkit.json: WebKit Linux Oilpan Leak - chromium.webkit.json: WebKit Linux Trusty - chromium.webkit.json: WebKit Mac Oilpan - chromium.webkit.json: WebKit Mac Oilpan (dbg) - chromium.webkit.json: WebKit Mac10.10 - chromium.webkit.json: WebKit Mac10.6 - chromium.webkit.json: WebKit Mac10.6 (dbg) - chromium.webkit.json: WebKit Mac10.7 - chromium.webkit.json: WebKit Mac10.7 (dbg) - chromium.webkit.json: WebKit Mac10.8 - chromium.webkit.json: WebKit Mac10.9 - chromium.webkit.json: WebKit Mac10.9 (retina) - chromium.webkit.json: WebKit Win Oilpan - chromium.webkit.json: WebKit Win Oilpan (dbg) - chromium.webkit.json: WebKit Win x64 Builder - chromium.webkit.json: WebKit Win x64 Builder (dbg) - chromium.webkit.json: WebKit Win10 - chromium.webkit.json: WebKit Win7 - chromium.webkit.json: WebKit Win7 (dbg) - chromium.webkit.json: WebKit XP Ran: ./manage.py --convert blink_platform_unittests R=maruel@chromium.org,dpranke@chromium.org BUG=98637, 524758 Committed: https://crrev.com/0a610cf3646903ded6ef3faa68b31eefec97f8c5 Cr-Commit-Position: refs/heads/master@{#348754}

Patch Set 1 #

Patch Set 2 : merge changes and rerun manage.py #

Patch Set 3 : merge upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -0 lines) Patch
M build/gn_migration.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 17 chunks +51 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 1 26 chunks +78 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (3 generated)
joelo
Depends on https://codereview.chromium.org/1316763004/, which adds the corresponding isolate file and test target to the blink ...
5 years, 3 months ago (2015-08-26 00:54:50 UTC) #1
joelo
5 years, 3 months ago (2015-08-26 00:55:05 UTC) #2
joelo
maruel@ dpranke@: ptal? swarming verified in patch2 tryjobs
5 years, 3 months ago (2015-09-14 21:07:35 UTC) #3
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-14 21:09:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311253006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311253006/40001
5 years, 3 months ago (2015-09-14 21:45:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/40516) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 3 months ago (2015-09-14 21:53:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311253006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311253006/40001
5 years, 3 months ago (2015-09-14 22:03:46 UTC) #10
Dirk Pranke
rubber-stamp lgtm.
5 years, 3 months ago (2015-09-14 22:18:39 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-14 23:11:55 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/0a610cf3646903ded6ef3faa68b31eefec97f8c5 Cr-Commit-Position: refs/heads/master@{#348754}
5 years, 3 months ago (2015-09-14 23:12:41 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:36 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0a610cf3646903ded6ef3faa68b31eefec97f8c5
Cr-Commit-Position: refs/heads/master@{#348754}

Powered by Google App Engine
This is Rietveld 408576698