Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: Source/modules/quota/StorageManager.cpp

Issue 1317243002: [VR, Permission] Use appopriate type parameters for WebCallbacks (1/3) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/permissions/PermissionStatus.cpp ('k') | Source/modules/vr/VRGetDevicesCallback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/quota/StorageManager.cpp
diff --git a/Source/modules/quota/StorageManager.cpp b/Source/modules/quota/StorageManager.cpp
index acfac05c47ffca0fc9b78493d760830087db08fe..ab2734a117c27732990ab1f08b413f2807299669 100644
--- a/Source/modules/quota/StorageManager.cpp
+++ b/Source/modules/quota/StorageManager.cpp
@@ -18,18 +18,17 @@ namespace blink {
namespace {
-class DurableStorageQueryCallbacks final : public WebCallbacks<WebPermissionStatus*, void> {
+class DurableStorageQueryCallbacks final : public WebPermissionCallback {
public:
DurableStorageQueryCallbacks(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
}
- void onSuccess(WebPermissionStatus* rawStatus) override
+ void onSuccess(WebPermissionStatus status) override
{
- OwnPtr<WebPermissionStatus> status = adoptPtr(rawStatus);
String toReturn;
- switch (*status) {
+ switch (status) {
case WebPermissionStatusGranted:
toReturn = "granted";
break;
@@ -51,17 +50,16 @@ private:
Persistent<ScriptPromiseResolver> m_resolver;
};
-class DurableStorageRequestCallbacks final : public WebCallbacks<WebPermissionStatus*, void> {
+class DurableStorageRequestCallbacks final : public WebPermissionCallback {
public:
DurableStorageRequestCallbacks(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
}
- void onSuccess(WebPermissionStatus* rawStatus) override
+ void onSuccess(WebPermissionStatus status) override
{
- OwnPtr<WebPermissionStatus> status = adoptPtr(rawStatus);
- m_resolver->resolve(*status == WebPermissionStatusGranted);
+ m_resolver->resolve(status == WebPermissionStatusGranted);
}
void onError() override
{
« no previous file with comments | « Source/modules/permissions/PermissionStatus.cpp ('k') | Source/modules/vr/VRGetDevicesCallback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698