Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1317053004: Make VisiblePosition constructor private (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, nektarios, je_julie, blink-reviews-html_chromium.org, aboxhall, blink-reviews-style_chromium.org, sof, eae+blinkwatch, fs, kouhei+svg_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), groby+blinkspell_chromium.org, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, dmazzoni, rwlbuis, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make VisiblePosition constructor private This patch makes |VisiblePosition| constructor private by replacing it by |createVisiblePosition()| as preparation of simplify implemenation of |VisiblePosition| construction. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201612

Patch Set 1 : 2015-09-01T18:48:19 #

Total comments: 2

Patch Set 2 : 2015-09-02T12:44:47 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -277 lines) Patch
M Source/core/dom/Range.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/DOMSelection.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 12 chunks +19 lines, -19 lines 0 comments Download
M Source/core/editing/Editor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 15 chunks +32 lines, -32 lines 0 comments Download
M Source/core/editing/FrameSelectionTest.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/GranularityStrategyTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/PlainTextRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SelectionController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/editing/VisiblePositionTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 10 chunks +24 lines, -24 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 29 chunks +38 lines, -37 lines 0 comments Download
M Source/core/editing/commands/ApplyBlockElementCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/ApplyStyleCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/commands/BreakBlockquoteCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/commands/CompositeEditCommand.cpp View 15 chunks +25 lines, -25 lines 0 comments Download
M Source/core/editing/commands/DeleteSelectionCommand.cpp View 14 chunks +17 lines, -17 lines 0 comments Download
M Source/core/editing/commands/FormatBlockCommand.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/commands/IndentOutdentCommand.cpp View 7 chunks +13 lines, -13 lines 0 comments Download
M Source/core/editing/commands/InsertLineBreakCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/commands/InsertListCommand.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/commands/InsertTextCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/commands/MoveSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/ReplaceSelectionCommand.cpp View 13 chunks +17 lines, -17 lines 0 comments Download
M Source/core/editing/commands/TypingCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/iterators/TextIterator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/spellcheck/TextCheckingHelper.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-01 13:34:54 UTC) #2
tkent
lgtm https://codereview.chromium.org/1317053004/diff/1/Source/core/editing/VisibleUnits.cpp File Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/1317053004/diff/1/Source/core/editing/VisibleUnits.cpp#newcode1633 Source/core/editing/VisibleUnits.cpp:1633: // logic at the beginning of LayoutObject::VisiblePosition(). LayoutObject ...
5 years, 3 months ago (2015-09-01 23:21:17 UTC) #3
yosin_UTC9
2015-09-02T12:44:47
5 years, 3 months ago (2015-09-02 03:45:24 UTC) #4
yosin_UTC9
Thanks for reviewing! https://codereview.chromium.org/1317053004/diff/1/Source/core/editing/VisibleUnits.cpp File Source/core/editing/VisibleUnits.cpp (right): https://codereview.chromium.org/1317053004/diff/1/Source/core/editing/VisibleUnits.cpp#newcode1633 Source/core/editing/VisibleUnits.cpp:1633: // logic at the beginning of ...
5 years, 3 months ago (2015-09-02 03:46:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317053004/20001
5 years, 3 months ago (2015-09-02 03:46:35 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 05:00:29 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201612

Powered by Google App Engine
This is Rietveld 408576698