Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: Source/core/editing/DOMSelection.cpp

Issue 1317053004: Make VisiblePosition constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-02T12:44:47 Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Range.cpp ('k') | Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/DOMSelection.cpp
diff --git a/Source/core/editing/DOMSelection.cpp b/Source/core/editing/DOMSelection.cpp
index 594b4917324e01b3a2ab5f365a38d854cbde99d4..c4eb56c34040be26a1b3840402576c059cc5f409 100644
--- a/Source/core/editing/DOMSelection.cpp
+++ b/Source/core/editing/DOMSelection.cpp
@@ -233,7 +233,7 @@ void DOMSelection::collapseToEnd(ExceptionState& exceptionState)
return;
}
- m_frame->selection().moveTo(VisiblePosition(selection.end()));
+ m_frame->selection().moveTo(createVisiblePosition(selection.end()));
}
void DOMSelection::collapseToStart(ExceptionState& exceptionState)
@@ -248,7 +248,7 @@ void DOMSelection::collapseToStart(ExceptionState& exceptionState)
return;
}
- m_frame->selection().moveTo(VisiblePosition(selection.start()));
+ m_frame->selection().moveTo(createVisiblePosition(selection.start()));
}
void DOMSelection::empty()
@@ -276,8 +276,8 @@ void DOMSelection::setBaseAndExtent(Node* baseNode, int baseOffset, Node* extent
if (!isValidForPosition(baseNode) || !isValidForPosition(extentNode))
return;
- VisiblePosition visibleBase = VisiblePosition(Position(baseNode, baseOffset));
- VisiblePosition visibleExtent = VisiblePosition(Position(extentNode, extentOffset));
+ VisiblePosition visibleBase = createVisiblePosition(Position(baseNode, baseOffset));
+ VisiblePosition visibleExtent = createVisiblePosition(Position(extentNode, extentOffset));
m_frame->selection().moveTo(visibleBase, visibleExtent);
}
@@ -351,7 +351,7 @@ void DOMSelection::extend(Node* node, int offset, ExceptionState& exceptionState
if (!isValidForPosition(node))
return;
- m_frame->selection().setExtent(VisiblePosition(Position(node, offset)));
+ m_frame->selection().setExtent(createVisiblePosition(Position(node, offset)));
}
PassRefPtrWillBeRawPtr<Range> DOMSelection::getRangeAt(int index, ExceptionState& exceptionState)
« no previous file with comments | « Source/core/dom/Range.cpp ('k') | Source/core/editing/EditingUtilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698