Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: Source/core/svg/SVGTextContentElement.cpp

Issue 1317053004: Make VisiblePosition constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-02T12:44:47 Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 exceptionState.throwDOMException(IndexSizeError, ExceptionMessages::inde xExceedsMaximumBound("charnum", charnum, getNumberOfChars())); 181 exceptionState.throwDOMException(IndexSizeError, ExceptionMessages::inde xExceedsMaximumBound("charnum", charnum, getNumberOfChars()));
182 return; 182 return;
183 } 183 }
184 184
185 if (nchars > numberOfChars - charnum) 185 if (nchars > numberOfChars - charnum)
186 nchars = numberOfChars - charnum; 186 nchars = numberOfChars - charnum;
187 187
188 ASSERT(document().frame()); 188 ASSERT(document().frame());
189 189
190 // Find selection start 190 // Find selection start
191 VisiblePosition start(firstPositionInNode(const_cast<SVGTextContentElement*> (this))); 191 VisiblePosition start = createVisiblePosition(firstPositionInNode(const_cast <SVGTextContentElement*>(this)));
192 for (unsigned i = 0; i < charnum; ++i) 192 for (unsigned i = 0; i < charnum; ++i)
193 start = nextPositionOf(start); 193 start = nextPositionOf(start);
194 194
195 // Find selection end 195 // Find selection end
196 VisiblePosition end(start); 196 VisiblePosition end(start);
197 for (unsigned i = 0; i < nchars; ++i) 197 for (unsigned i = 0; i < nchars; ++i)
198 end = nextPositionOf(end); 198 end = nextPositionOf(end);
199 199
200 document().frame()->selection().setSelection(VisibleSelection(start, end)); 200 document().frame()->selection().setSelection(VisibleSelection(start, end));
201 } 201 }
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 258
259 if (!layoutObject->isSVGText() && !layoutObject->isSVGInline()) 259 if (!layoutObject->isSVGText() && !layoutObject->isSVGInline())
260 return nullptr; 260 return nullptr;
261 261
262 SVGElement* element = toSVGElement(layoutObject->node()); 262 SVGElement* element = toSVGElement(layoutObject->node());
263 ASSERT(element); 263 ASSERT(element);
264 return isSVGTextContentElement(*element) ? toSVGTextContentElement(element) : 0; 264 return isSVGTextContentElement(*element) ? toSVGTextContentElement(element) : 0;
265 } 265 }
266 266
267 } 267 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLTextFormControlElementTest.cpp ('k') | Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698