Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Side by Side Diff: Source/core/editing/PlainTextRange.cpp

Issue 1317053004: Make VisiblePosition constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-02T12:44:47 Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
3 * Copyright (C) 2005 Alexey Proskuryakov. 3 * Copyright (C) 2005 Alexey Proskuryakov.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 // in those cases that textRunRange is used. 106 // in those cases that textRunRange is used.
107 if (foundEnd) { 107 if (foundEnd) {
108 // FIXME: This is a workaround for the fact that the end of a run 108 // FIXME: This is a workaround for the fact that the end of a run
109 // is often at the wrong position for emitted '\n's or if the 109 // is often at the wrong position for emitted '\n's or if the
110 // layoutObject of the current node is a replaced element. 110 // layoutObject of the current node is a replaced element.
111 if (len == 1 && (it.text().characterAt(0) == '\n' || it.isInsideRepl acedElement())) { 111 if (len == 1 && (it.text().characterAt(0) == '\n' || it.isInsideRepl acedElement())) {
112 it.advance(); 112 it.advance();
113 if (!it.atEnd()) { 113 if (!it.atEnd()) {
114 textRunEndPosition = it.startPositionInCurrentContainer(); 114 textRunEndPosition = it.startPositionInCurrentContainer();
115 } else { 115 } else {
116 Position runEnd = nextPositionOf(VisiblePosition(textRunStar tPosition)).deepEquivalent(); 116 Position runEnd = nextPositionOf(createVisiblePosition(textR unStartPosition)).deepEquivalent();
117 if (runEnd.isNotNull()) 117 if (runEnd.isNotNull())
118 textRunEndPosition = runEnd; 118 textRunEndPosition = runEnd;
119 } 119 }
120 } 120 }
121 } 121 }
122 122
123 if (foundStart) { 123 if (foundStart) {
124 startRangeFound = true; 124 startRangeFound = true;
125 if (textRunStartPosition.computeContainerNode()->isTextNode()) { 125 if (textRunStartPosition.computeContainerNode()->isTextNode()) {
126 int offset = start() - docTextPosition; 126 int offset = start() - docTextPosition;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 181
182 return PlainTextRange(start, end); 182 return PlainTextRange(start, end);
183 } 183 }
184 184
185 PlainTextRange PlainTextRange::create(const ContainerNode& scope, const Range& r ange) 185 PlainTextRange PlainTextRange::create(const ContainerNode& scope, const Range& r ange)
186 { 186 {
187 return create(scope, EphemeralRange(&range)); 187 return create(scope, EphemeralRange(&range));
188 } 188 }
189 189
190 } 190 }
OLDNEW
« no previous file with comments | « Source/core/editing/GranularityStrategyTest.cpp ('k') | Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698