Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316233007: Remove the old didFirstVisuallyNonEmptyLayout hook. (Closed)

Created:
5 years, 3 months ago by dglazkov
Modified:
5 years, 3 months ago
Reviewers:
esprehn, dcheng
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, tyoshino+watch_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Now that we started using the new didFirstVisuallyNonEmptyLayout hook, remove the old stuff. This is a final installment in the series: 1) https://codereview.chromium.org/1318283003 2) https://codereview.chromium.org/1319073003. BUG=521149 R=esprehn,dcheng Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201582

Patch Set 1 #

Patch Set 2 : Missed one more thing to remove. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebFrameClient.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316233007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316233007/1
5 years, 3 months ago (2015-09-01 19:51:41 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 21:02:57 UTC) #4
dglazkov
PTAL.
5 years, 3 months ago (2015-09-01 21:08:40 UTC) #5
dglazkov
On 2015/09/01 at 21:08:40, dglazkov wrote: > PTAL. Oops forgot one more place. New patch ...
5 years, 3 months ago (2015-09-01 21:12:52 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316233007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316233007/20001
5 years, 3 months ago (2015-09-01 21:26:05 UTC) #8
dglazkov
On 2015/09/01 at 21:26:05, commit-bot wrote: > Dry run: CQ is trying da patch. Follow ...
5 years, 3 months ago (2015-09-01 21:54:53 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 22:50:45 UTC) #11
esprehn
lgtm
5 years, 3 months ago (2015-09-01 23:07:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316233007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316233007/20001
5 years, 3 months ago (2015-09-01 23:07:59 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 23:13:27 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201582

Powered by Google App Engine
This is Rietveld 408576698