Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318283003: Organize Layout/Paint-related hooks (blink-side). (Closed)

Created:
5 years, 3 months ago by dglazkov
Modified:
5 years, 3 months ago
Reviewers:
esprehn, dcheng
CC:
blink-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, tyoshino+watch_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Organize Layout/Paint-related hooks (blink-side). Move didFirstLayoutAfterFinishedParsing and didFirstVisuallyNonEmptyLayout to WebWidgetClient, to signify that these are not [Web][Local]Frame-related, but rather WebFrameWidget-related hooks. R=dcheng,esprehn BUG=521149 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M Source/core/loader/FrameLoaderClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M public/web/WebViewClient.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/web/WebWidgetClient.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318283003/1
5 years, 3 months ago (2015-08-28 18:41:16 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/38025)
5 years, 3 months ago (2015-08-28 18:43:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318283003/1
5 years, 3 months ago (2015-08-28 19:42:38 UTC) #6
dglazkov
PTAL.
5 years, 3 months ago (2015-08-28 19:43:59 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 19:51:09 UTC) #9
dcheng
lgtm
5 years, 3 months ago (2015-08-28 20:07:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318283003/1
5 years, 3 months ago (2015-08-28 20:11:21 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 20:16:30 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201422

Powered by Google App Engine
This is Rietveld 408576698