Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1319073003: Organize Layout Hooks (content-side). (Closed)

Created:
5 years, 3 months ago by dglazkov
Modified:
5 years, 3 months ago
Reviewers:
Ian Wen, dcheng, nasko
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Organize Layout Hooks (content-side). Move layout-related hooks into WebWidgetClient and adjust the plumbing accordingly. R=dcheng,nasko BUG=521194 Committed: https://crrev.com/79c426103b6592f3d2cb4518f62395627897cf9b Cr-Commit-Position: refs/heads/master@{#346473}

Patch Set 1 #

Patch Set 2 : Why render_frame_impl, when you got render_widget. #

Patch Set 3 : Applied polish. #

Patch Set 4 : Updated comments #

Patch Set 5 : Fix aura and linux test failures. #

Total comments: 1

Patch Set 6 : Comments tweaked. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/common/frame_messages.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319073003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319073003/60001
5 years, 3 months ago (2015-08-28 20:33:00 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/127803)
5 years, 3 months ago (2015-08-28 20:46:28 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319073003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319073003/70001
5 years, 3 months ago (2015-08-28 20:51:18 UTC) #7
dglazkov
PTAL.
5 years, 3 months ago (2015-08-28 22:30:44 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 22:36:49 UTC) #10
dcheng
https://codereview.chromium.org/1319073003/diff/70001/content/common/view_messages.h File content/common/view_messages.h (right): https://codereview.chromium.org/1319073003/diff/70001/content/common/view_messages.h#newcode1518 content/common/view_messages.h:1518: // after the frame has painted something. "frame" -> ...
5 years, 3 months ago (2015-08-31 16:46:02 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319073003/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319073003/90001
5 years, 3 months ago (2015-08-31 18:11:27 UTC) #13
dcheng
lgtm
5 years, 3 months ago (2015-08-31 19:45:35 UTC) #14
nasko
LGTM
5 years, 3 months ago (2015-08-31 20:53:56 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 21:13:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319073003/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319073003/90001
5 years, 3 months ago (2015-08-31 21:14:34 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 3 months ago (2015-08-31 21:22:50 UTC) #20
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/79c426103b6592f3d2cb4518f62395627897cf9b Cr-Commit-Position: refs/heads/master@{#346473}
5 years, 3 months ago (2015-08-31 21:23:24 UTC) #21
Ian Wen
Looks like the wrong bug number was referenced.
5 years, 3 months ago (2015-08-31 22:07:16 UTC) #23
dglazkov
5 years, 3 months ago (2015-08-31 22:11:25 UTC) #24
Message was sent while issue was closed. 
On 2015/08/31 at 22:07:16, ianwen wrote:
> Looks like the wrong bug number was referenced.

Whoops. Sorry. For posterity, here's the bug URL:
https://code.google.com/p/chromium/issues/detail?id=521149

Powered by Google App Engine
This is Rietveld 408576698