Source/web/WebViewImpl.cpp - Issue 1316233007: Remove the old didFirstVisuallyNonEmptyLayout hook.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 1316233007: Remove the old didFirstVisuallyNonEmptyLayout hook. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Missed one more thing to remove. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 7d7ae970d4ac9b0388845d1e5d457848a017e079..74e84cf44694529c5a7df45bb72f1dcd9b76e8e3 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -1905,8 +1905,6 @@ void WebViewImpl::layout()

m_shouldDispatchFirstVisuallyNonEmptyLayout = false;

// TODO(esprehn): Move users of this callback to something

// better, the heuristic for "visually non-empty" is bad.

- // TODO(dglazkov): Remove this line after https://codereview.chromium.org/1319073003 lands.

- frame->loader().client()->dispatchDidFirstVisuallyNonEmptyLayout();

client()->didFirstVisuallyNonEmptyLayout();

}

« no previous file with comments | « Source/web/FrameLoaderClientImpl.cpp ('k') | public/web/WebFrameClient.h » ('j') | no next file with comments »