Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1315303004: Turn components/crash into a layered component. (Closed)

Created:
5 years, 3 months ago by sdefresne
Modified:
5 years, 3 months ago
CC:
android-webview-reviews_chromium.org, blundell+watchlist_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, droger+watchlist_chromium.org, dzhioev+watch_chromium.org, gunsch+watch_chromium.org, jochen+watch_chromium.org, kalyank, lcwu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, native-client-reviews_googlegroups.com, oshima+watch_chromium.org, sadrul, sdefresne+watchlist_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn components/crash into a layered component. The crash component cannot be used on iOS (as it depends on //content). Turn it into a layered component so that it is possible to put shared code related to crash there (components/crash_keys and objc_zombie.{h,mm}). BUG=522955 TBR=sky@chromium.org TBR=jschuh@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/8ba0b88ca93a3ec2fc75e5fb3afdc49775313ad3 Cr-Commit-Position: refs/heads/master@{#349643}

Patch Set 1 #

Patch Set 2 : Fix gn build #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase to fix patch failures #

Patch Set 6 : Fix compilation on Windows with gn #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -6407 lines) Patch
M BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT_test.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M WATCHLISTS View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M android_webview/crash_reporter/aw_microdump_crash_reporter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_crash_reporter_client.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/client_util.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/kasko_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/breakpad.isolate View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/crash_upload_list_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_settings_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_exe_win_64.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/crash_service/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M chromecast/app/android/cast_crash_reporter_client_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/android/crash_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/app/cast_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/linux/cast_crash_reporter_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/app/linux/cast_crash_reporter_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/cast_browser_process.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M components/BUILD.gn View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M components/components.gyp View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M components/crash.gypi View 1 chunk +290 lines, -286 lines 0 comments Download
A components/crash/README View 1 chunk +2 lines, -0 lines 0 comments Download
D components/crash/app/BUILD.gn View 1 chunk +0 lines, -79 lines 0 comments Download
D components/crash/app/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D components/crash/app/breakpad_linux.h View 1 chunk +0 lines, -32 lines 0 comments Download
D components/crash/app/breakpad_linux.cc View 1 chunk +0 lines, -1760 lines 0 comments Download
D components/crash/app/breakpad_linux_impl.h View 1 chunk +0 lines, -65 lines 0 comments Download
D components/crash/app/breakpad_mac.h View 1 chunk +0 lines, -27 lines 0 comments Download
D components/crash/app/breakpad_mac.mm View 1 chunk +0 lines, -286 lines 0 comments Download
D components/crash/app/breakpad_mac_stubs.mm View 1 chunk +0 lines, -24 lines 0 comments Download
D components/crash/app/breakpad_win.h View 1 chunk +0 lines, -28 lines 0 comments Download
D components/crash/app/breakpad_win.cc View 1 chunk +0 lines, -745 lines 0 comments Download
D components/crash/app/crash_keys_win.h View 1 chunk +0 lines, -82 lines 0 comments Download
D components/crash/app/crash_keys_win.cc View 1 chunk +0 lines, -192 lines 0 comments Download
D components/crash/app/crash_keys_win_unittest.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D components/crash/app/crash_reporter_client.h View 1 chunk +0 lines, -158 lines 0 comments Download
D components/crash/app/crash_reporter_client.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D components/crash/app/crashpad_mac.h View 1 chunk +0 lines, -54 lines 0 comments Download
D components/crash/app/crashpad_mac.mm View 1 chunk +0 lines, -251 lines 0 comments Download
D components/crash/app/hard_error_handler_win.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/crash/app/hard_error_handler_win.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D components/crash/browser/BUILD.gn View 1 chunk +0 lines, -38 lines 0 comments Download
D components/crash/browser/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/crash/browser/crash_dump_manager_android.h View 1 chunk +0 lines, -85 lines 0 comments Download
D components/crash/browser/crash_dump_manager_android.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D components/crash/browser/crash_handler_host_linux.h View 1 chunk +0 lines, -93 lines 0 comments Download
D components/crash/browser/crash_handler_host_linux.cc View 1 chunk +0 lines, -437 lines 0 comments Download
A + components/crash/content/app/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/content/app/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/content/app/breakpad_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/app/breakpad_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/app/breakpad_linux_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/crash/content/app/breakpad_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/app/breakpad_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/crash/content/app/breakpad_mac_stubs.mm View 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/content/app/breakpad_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/app/breakpad_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/crash/content/app/crash_keys_win.h View 2 chunks +5 lines, -0 lines 0 comments Download
A + components/crash/content/app/crash_keys_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/crash/content/app/crash_keys_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/crash/content/app/crash_reporter_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/app/crash_reporter_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/content/app/crashpad_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/app/crashpad_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/crash/content/app/hard_error_handler_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/app/hard_error_handler_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/crash/content/browser/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/content/browser/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/content/browser/crash_dump_manager_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/browser/crash_dump_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/content/browser/crash_handler_host_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/browser/crash_handler_host_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/tools/BUILD.gn View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/content/tools/crash_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/crash/content/tools/crash_service.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/crash/content/tools/dmp2minidump.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/crash/content/tools/generate_breakpad_symbols.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D components/crash/tools/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D components/crash/tools/crash_service.h View 1 chunk +0 lines, -125 lines 0 comments Download
D components/crash/tools/crash_service.cc View 1 chunk +0 lines, -487 lines 0 comments Download
D components/crash/tools/dmp2minidump.py View 1 chunk +0 lines, -51 lines 0 comments Download
D components/crash/tools/generate_breakpad_symbols.py View 1 chunk +0 lines, -262 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_crash_reporter_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_main_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/tools/content_shell_crash_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/breakpad_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/msan/blacklist.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 63 (19 generated)
sdefresne
blundell: please review as you're familiar with layered componentization rsesek: please review as OWNERS of ...
5 years, 3 months ago (2015-09-02 12:41:43 UTC) #2
blundell
On 2015/09/02 12:41:43, sdefresne wrote: > blundell: please review as you're familiar with layered componentization ...
5 years, 3 months ago (2015-09-03 13:19:32 UTC) #3
sdefresne
rsesek: ping?
5 years, 3 months ago (2015-09-03 16:44:39 UTC) #4
sdefresne
rsesek: ping?
5 years, 3 months ago (2015-09-07 07:55:18 UTC) #5
Robert Sesek
On 2015/09/07 07:55:18, sdefresne wrote: > rsesek: ping? Sorry, you sent this when I was ...
5 years, 3 months ago (2015-09-08 19:19:16 UTC) #6
blundell
On 2015/09/08 19:19:16, Robert Sesek wrote: > On 2015/09/07 07:55:18, sdefresne wrote: > > rsesek: ...
5 years, 3 months ago (2015-09-09 13:24:46 UTC) #7
sdefresne
On 2015/09/09 at 13:24:46, blundell wrote: > On 2015/09/08 19:19:16, Robert Sesek wrote: > > ...
5 years, 3 months ago (2015-09-10 10:22:46 UTC) #8
sdefresne
On 2015/09/10 at 10:22:46, sdefresne wrote: > On 2015/09/09 at 13:24:46, blundell wrote: > > ...
5 years, 3 months ago (2015-09-10 10:25:31 UTC) #9
Robert Sesek
On 2015/09/10 10:25:31, sdefresne wrote: > On 2015/09/10 at 10:22:46, sdefresne wrote: > > On ...
5 years, 3 months ago (2015-09-11 14:56:55 UTC) #11
Mark Mentovai
I see both of your points, and I could probably be swayed either way, however, ...
5 years, 3 months ago (2015-09-11 15:25:52 UTC) #12
sdefresne
On 2015/09/11 at 15:25:52, mark wrote: > I see both of your points, and I ...
5 years, 3 months ago (2015-09-11 17:01:33 UTC) #13
blundell
Thanks, Mark. I defer to your and Robert's opinion here. I'm capturing my reaction to ...
5 years, 3 months ago (2015-09-14 08:07:04 UTC) #14
sdefresne
Landing this CL as-is with objection from blundell@ noted as this is blocking the componentization ...
5 years, 3 months ago (2015-09-15 09:22:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315303004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315303004/60001
5 years, 3 months ago (2015-09-15 09:22:44 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/69270)
5 years, 3 months ago (2015-09-15 09:25:03 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315303004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315303004/80001
5 years, 3 months ago (2015-09-15 12:55:34 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99832)
5 years, 3 months ago (2015-09-15 13:05:54 UTC) #24
sdefresne
cpu@ needs OWNERS review for "new" DEPS on (not really new, just moved) src/sandbox jam@ ...
5 years, 3 months ago (2015-09-15 13:18:02 UTC) #26
sdefresne
-cpu, +jschuh
5 years, 3 months ago (2015-09-16 08:44:51 UTC) #28
sdefresne
TBR-ing OWNERS of affected files with the rationale that this CL only shuffle files around ...
5 years, 3 months ago (2015-09-16 08:48:21 UTC) #29
sdefresne
Using NOPRESUBMIT=true because I'm moving a file that raises the following PRESUBMIT error (the file ...
5 years, 3 months ago (2015-09-16 08:50:01 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315303004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315303004/80001
5 years, 3 months ago (2015-09-16 08:50:29 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/41347)
5 years, 3 months ago (2015-09-16 09:06:53 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315303004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315303004/80001
5 years, 3 months ago (2015-09-16 12:53:07 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/41436)
5 years, 3 months ago (2015-09-16 13:44:01 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315303004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315303004/100001
5 years, 3 months ago (2015-09-16 14:53:45 UTC) #41
jam
On 2015/09/15 13:18:02, sdefresne wrote: > cpu@ needs OWNERS review for "new" DEPS on (not ...
5 years, 3 months ago (2015-09-16 15:38:37 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/107944)
5 years, 3 months ago (2015-09-16 15:45:24 UTC) #44
sdefresne
Failures look like flakes, resending to the CQ.
5 years, 3 months ago (2015-09-17 08:09:04 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315303004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315303004/100001
5 years, 3 months ago (2015-09-17 08:09:18 UTC) #47
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-09-17 08:45:13 UTC) #48
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/4e483c64be5136b785e92c5baa971baca7eea2bc Cr-Commit-Position: refs/heads/master@{#349384}
5 years, 3 months ago (2015-09-17 08:46:02 UTC) #49
sdefresne
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1351923002/ by sdefresne@chromium.org. ...
5 years, 3 months ago (2015-09-17 14:24:37 UTC) #50
sdefresne
On 2015/09/17 at 14:24:37, sdefresne wrote: > A revert of this CL (patchset #6 id:100001) ...
5 years, 3 months ago (2015-09-17 14:25:08 UTC) #51
sdefresne
Hi Robert, I don't know why my change breaks WebKit. My understanding is that Chromium ...
5 years, 3 months ago (2015-09-17 14:28:55 UTC) #52
sdefresne
On 2015/09/17 at 14:28:55, sdefresne wrote: > Hi Robert, I don't know why my change ...
5 years, 3 months ago (2015-09-17 14:32:00 UTC) #53
Robert Sesek
On 2015/09/17 14:32:00, sdefresne wrote: > On 2015/09/17 at 14:28:55, sdefresne wrote: > > Hi ...
5 years, 3 months ago (2015-09-17 16:12:31 UTC) #54
sdefresne
On 2015/09/17 at 16:12:31, rsesek wrote: > On 2015/09/17 14:32:00, sdefresne wrote: > > On ...
5 years, 3 months ago (2015-09-17 16:39:30 UTC) #55
sdefresne
On 2015/09/17 at 16:39:30, sdefresne wrote: > On 2015/09/17 at 16:12:31, rsesek wrote: > > ...
5 years, 3 months ago (2015-09-17 17:48:34 UTC) #56
sdefresne
On 2015/09/17 at 17:48:34, sdefresne wrote: > On 2015/09/17 at 16:39:30, sdefresne wrote: > > ...
5 years, 3 months ago (2015-09-18 09:00:54 UTC) #57
sdefresne
Sending back to the CQ.
5 years, 3 months ago (2015-09-18 09:15:55 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315303004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315303004/120001
5 years, 3 months ago (2015-09-18 09:16:01 UTC) #61
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 3 months ago (2015-09-18 10:33:23 UTC) #62
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 10:34:08 UTC) #63
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/8ba0b88ca93a3ec2fc75e5fb3afdc49775313ad3
Cr-Commit-Position: refs/heads/master@{#349643}

Powered by Google App Engine
This is Rietveld 408576698