Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1354683002: Update to the new location of the generate_breakpad_symbols.py script. (Closed)

Created:
5 years, 3 months ago by Stephen White
Modified:
5 years, 3 months ago
CC:
sdefresne, blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update to the new location of the generate_breakpad_symbols.py script. This script will be moved by https://codereview.chromium.org/1315303004/ when it re-lands. Update to the new location in dump_reader_multipart.py, and temporarily disable the check_breakpad_symbols_actually_exists test to keep the bots green. BUG=522955 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354683002/1
5 years, 3 months ago (2015-09-17 17:38:58 UTC) #2
Stephen White
jochen@: PTAL. I'm trying to help sdefresne@ re-land https://codereview.chromium.org/1315303004/ without turning the bots red.
5 years, 3 months ago (2015-09-17 17:43:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 18:13:16 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-18 08:34:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354683002/1
5 years, 3 months ago (2015-09-18 09:04:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202514
5 years, 3 months ago (2015-09-18 09:10:21 UTC) #10
sdefresne
5 years, 3 months ago (2015-09-18 12:25:17 UTC) #11
Message was sent while issue was closed.
CL to re-enable the test is ready there:
https://codereview.chromium.org/1357633002

Powered by Google App Engine
This is Rietveld 408576698