Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2083)

Unified Diff: components/crash/browser/crash_dump_manager_android.h

Issue 1315303004: Turn components/crash into a layered component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/browser/DEPS ('k') | components/crash/browser/crash_dump_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/browser/crash_dump_manager_android.h
diff --git a/components/crash/browser/crash_dump_manager_android.h b/components/crash/browser/crash_dump_manager_android.h
deleted file mode 100644
index 18d285995f1e494eb9df0300cc59892599f99690..0000000000000000000000000000000000000000
--- a/components/crash/browser/crash_dump_manager_android.h
+++ /dev/null
@@ -1,85 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
-#define COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
-
-#include <map>
-
-#include "base/files/file.h"
-#include "base/files/file_path.h"
-#include "base/process/process.h"
-#include "base/synchronization/lock.h"
-#include "content/public/browser/browser_child_process_observer.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
-
-namespace content {
-class RenderProcessHost;
-}
-
-namespace breakpad {
-
-// This class manages the crash minidumps.
-// On Android, because of process isolation, each renderer process runs with a
-// different UID. As a result, we cannot generate the minidumps in the browser
-// (as the browser process does not have access to some system files for the
-// crashed process). So the minidump is generated in the renderer process.
-// Since the isolated process cannot open files, we provide it on creation with
-// a file descriptor where to write the minidump in the event of a crash.
-// This class creates these file descriptors and associates them with render
-// processes and take the appropriate action when the render process terminates.
-class CrashDumpManager : public content::BrowserChildProcessObserver,
- public content::NotificationObserver {
- public:
- // The embedder should create a single instance of the CrashDumpManager.
- static CrashDumpManager* GetInstance();
-
- // Should be created on the UI thread.
- explicit CrashDumpManager(const base::FilePath& crash_dump_dir);
-
- ~CrashDumpManager() override;
-
- // Returns a file that should be used to generate a minidump for the process
- // |child_process_id|.
- base::File CreateMinidumpFile(int child_process_id);
-
- private:
- typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath;
-
- static void ProcessMinidump(const base::FilePath& minidump_path,
- base::ProcessHandle pid);
-
- // content::BrowserChildProcessObserver implementation:
- void BrowserChildProcessHostDisconnected(
- const content::ChildProcessData& data) override;
- void BrowserChildProcessCrashed(
- const content::ChildProcessData& data,
- int exit_code) override;
-
- // NotificationObserver implementation:
- void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
-
- // Called on child process exit (including crash).
- void OnChildExit(int child_process_id, base::ProcessHandle pid);
-
- content::NotificationRegistrar notification_registrar_;
-
- // This map should only be accessed with its lock aquired as it is accessed
- // from the PROCESS_LAUNCHER and UI threads.
- base::Lock child_process_id_to_minidump_path_lock_;
- ChildProcessIDToMinidumpPath child_process_id_to_minidump_path_;
-
- base::FilePath crash_dump_dir_;
-
- static CrashDumpManager* instance_;
-
- DISALLOW_COPY_AND_ASSIGN(CrashDumpManager);
-};
-
-} // namespace breakpad
-
-#endif // COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
« no previous file with comments | « components/crash/browser/DEPS ('k') | components/crash/browser/crash_dump_manager_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698