Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: PRESUBMIT_test.py

Issue 1315303004: Turn components/crash into a layered component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | WATCHLISTS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import glob 6 import glob
7 import json 7 import json
8 import os 8 import os
9 import re 9 import re
10 import subprocess 10 import subprocess
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 '"+tools/memory_watcher",', 475 '"+tools/memory_watcher",',
476 '"+third_party/lss/linux_syscall_support.h",', 476 '"+third_party/lss/linux_syscall_support.h",',
477 ] 477 ]
478 files_to_check = PRESUBMIT._FilesToCheckForIncomingDeps(re, changed_lines) 478 files_to_check = PRESUBMIT._FilesToCheckForIncomingDeps(re, changed_lines)
479 expected = set([ 479 expected = set([
480 'breakpad/DEPS', 480 'breakpad/DEPS',
481 'chrome/installer/DEPS', 481 'chrome/installer/DEPS',
482 'chrome/plugin/chrome_content_plugin_client.h', 482 'chrome/plugin/chrome_content_plugin_client.h',
483 'chrome/utility/chrome_content_utility_client.h', 483 'chrome/utility/chrome_content_utility_client.h',
484 'chromeos/chromeos_paths.h', 484 'chromeos/chromeos_paths.h',
485 'components/crash/DEPS', 485 'components/crash/content/DEPS',
486 'components/nacl/common/DEPS', 486 'components/nacl/common/DEPS',
487 'content/public/browser/render_process_host.h', 487 'content/public/browser/render_process_host.h',
488 'policy/DEPS', 488 'policy/DEPS',
489 'sandbox/DEPS', 489 'sandbox/DEPS',
490 'tools/memory_watcher/DEPS', 490 'tools/memory_watcher/DEPS',
491 'third_party/lss/linux_syscall_support.h', 491 'third_party/lss/linux_syscall_support.h',
492 ]) 492 ])
493 self.assertEqual(expected, files_to_check); 493 self.assertEqual(expected, files_to_check);
494 494
495 495
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
919 self.assertTrue('HasInlineTag.java:4' in msgs[2].items) 919 self.assertTrue('HasInlineTag.java:4' in msgs[2].items)
920 920
921 # Util Log usage 921 # Util Log usage
922 self.assertEqual(2, len(msgs[3].items)) 922 self.assertEqual(2, len(msgs[3].items))
923 self.assertTrue('HasAndroidLog.java:3' in msgs[3].items) 923 self.assertTrue('HasAndroidLog.java:3' in msgs[3].items)
924 self.assertTrue('IsInBasePackageButImportsLog.java:4' in msgs[3].items) 924 self.assertTrue('IsInBasePackageButImportsLog.java:4' in msgs[3].items)
925 925
926 926
927 if __name__ == '__main__': 927 if __name__ == '__main__':
928 unittest.main() 928 unittest.main()
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | WATCHLISTS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698