Include default communication devices in audio device enumerations. This removes heuristic that pic…

Include default communication devices in audio device enumerations. This removes heuristic that picks the communications output device for rendering when associated with an active communications capture device.  It also removes the goog specific constraint we offered to turn off ducking, since ducking will now always be turned off for the default device.

BUG=525443
Committed: https://crrev.com/13c341a15d70751583937a2608ae82525010f7b3
Cr-Commit-Position: refs/heads/master@{#346113}

[tommi (sloooow) - chröme, 2015-08-27 15:06:51]

tommi@chromium.org changed reviewers:
+ dalecurtis@chromium.org, henrika@chromium.org

[tommi (sloooow) - chröme, 2015-08-27 15:06:51]

Hey guys - I'd like both of you to take a look at this if you don't mind.  It's
a lot of file but it's mostly removing code (-222) and a tiny bit of new code ;)

[tommi (sloooow) - chröme, 2015-08-27 15:07:10]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-27 15:07:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314803003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314803003/1

[DaleCurtis, 2015-08-27 16:23:34]

Nice cleanup, this solution seems a lot more elegant! I suppose our bots have
any communications devices, so adding an AudioManager test for this wouldn't
work?


lgtm either way

https://codereview.chromium.org/1314803003/diff/1/content/renderer/media/webr...
File content/renderer/media/webrtc_audio_renderer.cc (right):

https://codereview.chromium.org/1314803003/diff/1/content/renderer/media/webr...
content/renderer/media/webrtc_audio_renderer.cc:188: frames_per_buffer, 0),
Just delete, the 1-less constructor defaults this to off.

[commit-bot: I haz the power, 2015-08-27 16:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 16:47:30]

Dry run: This issue passed the CQ dry run.

[henrika (OOO until Aug 14), 2015-08-28 07:29:21]

Great work Tommi. Did you run the AudioManagerTest?

LGTM

[henrika (OOO until Aug 14), 2015-08-28 07:29:45]

https://codereview.chromium.org/1314803003/diff/1/media/audio/win/audio_low_l...
File media/audio/win/audio_low_latency_input_win.cc (right):

https://codereview.chromium.org/1314803003/diff/1/media/audio/win/audio_low_l...
media/audio/win/audio_low_latency_input_win.cc:435: if (device_id_ ==
AudioManagerBase::kDefaultDeviceId) {
This new version is so much easier to understand than the previous one. Thanks
for cleaning this up.

[tommi (sloooow) - chröme, 2015-08-28 07:33:24]

Address comment

[tommi (sloooow) - chröme, 2015-08-28 07:33:33]

https://codereview.chromium.org/1314803003/diff/1/content/renderer/media/webr...
File content/renderer/media/webrtc_audio_renderer.cc (right):

https://codereview.chromium.org/1314803003/diff/1/content/renderer/media/webr...
content/renderer/media/webrtc_audio_renderer.cc:188: frames_per_buffer, 0),
On 2015/08/27 16:23:34, DaleCurtis wrote:
> Just delete, the 1-less constructor defaults this to off.

Done.

[tommi (sloooow) - chröme, 2015-08-28 07:37:17]

Thanks.  Yes, ran the tests, tested some webrtc apps, the Hangouts extension and
that chromeRenderToAssociatedSink works as it should.  I'm going to sync with
Guido too to make sure this will be tested specially on Windows with the new
audio selection API too.
Lots of edge cases to test and I'll get some more folks to test it both
internally and externally once it's in.

https://codereview.chromium.org/1314803003/diff/1/media/audio/win/audio_low_l...
File media/audio/win/audio_low_latency_input_win.cc (right):

https://codereview.chromium.org/1314803003/diff/1/media/audio/win/audio_low_l...
media/audio/win/audio_low_latency_input_win.cc:435: if (device_id_ ==
AudioManagerBase::kDefaultDeviceId) {
On 2015/08/28 07:29:45, henrika wrote:
> This new version is so much easier to understand than the previous one. Thanks
> for cleaning this up.

Acknowledged.

[tommi (sloooow) - chröme, 2015-08-28 07:37:17]

Thanks.  Yes, ran the tests, tested some webrtc apps, the Hangouts extension and
that chromeRenderToAssociatedSink works as it should.  I'm going to sync with
Guido too to make sure this will be tested specially on Windows with the new
audio selection API too.
Lots of edge cases to test and I'll get some more folks to test it both
internally and externally once it's in.

https://codereview.chromium.org/1314803003/diff/1/media/audio/win/audio_low_l...
File media/audio/win/audio_low_latency_input_win.cc (right):

https://codereview.chromium.org/1314803003/diff/1/media/audio/win/audio_low_l...
media/audio/win/audio_low_latency_input_win.cc:435: if (device_id_ ==
AudioManagerBase::kDefaultDeviceId) {
On 2015/08/28 07:29:45, henrika wrote:
> This new version is so much easier to understand than the previous one. Thanks
> for cleaning this up.

Acknowledged.

[tommi (sloooow) - chröme, 2015-08-28 07:38:51]

whoa... sorry for the double click. apparently it causes double post :)

[tommi (sloooow) - chröme, 2015-08-28 07:38:58]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2015-08-28 07:38:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org, henrika@chromium.org
Link to the patchset: https://codereview.chromium.org/1314803003/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2015-08-28 07:39:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314803003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314803003/20001

[commit-bot: I haz the power, 2015-08-28 10:02:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-28 10:02:58]

Patchset 2 (id:??) landed as
https://crrev.com/13c341a15d70751583937a2608ae82525010f7b3
Cr-Commit-Position: refs/heads/master@{#346113}