Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1583)

Unified Diff: content/renderer/media/media_stream_audio_processor_options.cc

Issue 1314803003: Include default communication devices in audio device enumerations. This removes heuristic that pic… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_audio_processor_options.cc
diff --git a/content/renderer/media/media_stream_audio_processor_options.cc b/content/renderer/media/media_stream_audio_processor_options.cc
index 1f875f9525e0d89317c614bd20c6ec6dd659cbae..5c61a055cc47fd2e1bc014e2e385ad4af4710c9d 100644
--- a/content/renderer/media/media_stream_audio_processor_options.cc
+++ b/content/renderer/media/media_stream_audio_processor_options.cc
@@ -66,19 +66,9 @@ struct {
{ MediaAudioConstraints::kGoogTypingNoiseDetection, true },
{ MediaAudioConstraints::kGoogExperimentalNoiseSuppression, false },
{ MediaAudioConstraints::kGoogBeamforming, false },
-#if defined(OS_WIN)
- { kMediaStreamAudioDucking, true },
-#else
- { kMediaStreamAudioDucking, false },
-#endif
{ kMediaStreamAudioHotword, false },
};
-bool IsAudioProcessingConstraint(const std::string& key) {
- // |kMediaStreamAudioDucking| does not require audio processing.
- return key != kMediaStreamAudioDucking;
-}
-
// Used to log echo quality based on delay estimates.
enum DelayBasedEchoQuality {
DELAY_BASED_ECHO_QUALITY_GOOD = 0,
@@ -213,11 +203,7 @@ bool MediaAudioConstraints::IsValid() const {
bool MediaAudioConstraints::GetDefaultValueForConstraint(
const blink::WebMediaConstraints& constraints,
const std::string& key) const {
- // |kMediaStreamAudioDucking| is not restricted by
- // |default_audio_processing_constraint_value_| since it does not require
- // audio processing.
- if (!default_audio_processing_constraint_value_ &&
- IsAudioProcessingConstraint(key))
+ if (!default_audio_processing_constraint_value_)
return false;
for (size_t i = 0; i < arraysize(kDefaultAudioConstraints); ++i) {
« no previous file with comments | « content/common/media/media_stream_options.cc ('k') | content/renderer/media/media_stream_audio_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698