Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: content/browser/renderer_host/media/media_stream_manager.cc

Issue 1314803003: Include default communication devices in audio device enumerations. This removes heuristic that pic… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/media/media_stream_options.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/media_stream_manager.cc
diff --git a/content/browser/renderer_host/media/media_stream_manager.cc b/content/browser/renderer_host/media/media_stream_manager.cc
index a4a95e0aea2d142b8f6a93fd2fe96b652303ed68..5071bff1308920c61e35c4b6e1fa655128c52cfa 100644
--- a/content/browser/renderer_host/media/media_stream_manager.cc
+++ b/content/browser/renderer_host/media/media_stream_manager.cc
@@ -127,12 +127,7 @@ void ParseStreamType(const StreamOptions& options,
// explicitly turn them off.
void FilterAudioEffects(const StreamOptions& options, int* effects) {
DCHECK(effects);
- // TODO(ajm): Should we also handle ECHO_CANCELLER here?
- std::string value;
- if (options.GetFirstAudioConstraintByName(
- kMediaStreamAudioDucking, &value, NULL) && value == "false") {
- *effects &= ~media::AudioParameters::DUCKING;
- }
+ // TODO(ajm): Should we handle ECHO_CANCELLER here?
}
// Unlike other effects, hotword is off by default, so turn it on if it's
« no previous file with comments | « no previous file | content/common/media/media_stream_options.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698