Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: content/renderer/media/media_stream_audio_processor_unittest.cc

Issue 1314803003: Include default communication devices in audio device enumerations. This removes heuristic that pic… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_audio_processor_unittest.cc
diff --git a/content/renderer/media/media_stream_audio_processor_unittest.cc b/content/renderer/media/media_stream_audio_processor_unittest.cc
index 5a1d7a84c705966534ebb7e1b7bafffc27a77854..0e40ece9e5c4982c0b745540fe0c90dbf90a641a 100644
--- a/content/renderer/media/media_stream_audio_processor_unittest.cc
+++ b/content/renderer/media/media_stream_audio_processor_unittest.cc
@@ -337,7 +337,7 @@ TEST_F(MediaStreamAudioProcessorTest, VerifyConstraints) {
{
// When |kEchoCancellation| is explicitly set to false, the default values
- // for all the constraints except |kMediaStreamAudioDucking| are false.
+ // for all the constraints are false.
MockMediaConstraintFactory constraint_factory;
constraint_factory.AddOptional(MediaAudioConstraints::kEchoCancellation,
false);
@@ -347,11 +347,6 @@ TEST_F(MediaStreamAudioProcessorTest, VerifyConstraints) {
for (size_t i = 0; i < arraysize(kDefaultAudioConstraints); ++i) {
EXPECT_FALSE(audio_constraints.GetProperty(kDefaultAudioConstraints[i]));
}
-#if defined(OS_WIN)
- EXPECT_TRUE(audio_constraints.GetProperty(kMediaStreamAudioDucking));
-#else
- EXPECT_FALSE(audio_constraints.GetProperty(kMediaStreamAudioDucking));
-#endif
}
{
« no previous file with comments | « content/renderer/media/media_stream_audio_processor_options.cc ('k') | content/renderer/media/media_stream_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698