Migrate logging infrastructure Isolate->Thread

runtime/vm/log.h

Index: runtime/vm/log.h
diff --git a/runtime/vm/log.h b/runtime/vm/log.h
index f4c58e964cffb4b30c51dbf1a0186b8ab32d4d82..61c56969363b797910c42ecd4e1665f7371c410f 100644
--- a/runtime/vm/log.h
+++ b/runtime/vm/log.h
@@ -11,20 +11,20 @@
 
 namespace dart {
 
-class Isolate;
 class LogBlock;
 class Thread;
 
+// TODO(koda): Rename ISL_* -> THR_*.

[Ivan Posva, 2015/09/08 21:22:22]

Why not do the rename right now?

[koda, 2015/09/09 00:26:57]

Done.

 #if defined(_MSC_VER)
 #define ISL_Print(format, ...) \
-    Isolate::Current()->Log()->Print(format, __VA_ARGS__)
+    Thread::Current()->Log()->Print(format, __VA_ARGS__)
 #else
 #define ISL_Print(format, ...) \
-    Isolate::Current()->Log()->Print(format, ##__VA_ARGS__)
+    Thread::Current()->Log()->Print(format, ##__VA_ARGS__)
 #endif
 
 #define ISL_VPrint(format, args) \
-    Isolate::Current()->Log()->VPrint(format, args)
+    Thread::Current()->Log()->VPrint(format, args)
 
 typedef void (*LogPrinter)(const char* str, ...);
 
@@ -70,17 +70,14 @@ class Log {
 // Can be nested.
 class LogBlock : public StackResource {
  public:
-  LogBlock(Isolate* isolate, Log* log)
-      : StackResource(isolate),
+  LogBlock(Thread* thread, Log* log)
+      : StackResource(thread),
         log_(log), cursor_(log->cursor()) {
     CommonConstructor();
   }
 
-  explicit LogBlock(Isolate* isolate);
   explicit LogBlock(Thread* thread);

[Ivan Posva, 2015/09/08 21:22:22]

Is there a particular reason to have this constructor in the .cc file, while the
other is inlined?

[koda, 2015/09/09 00:26:57]

Done.

 
-  LogBlock(Thread* thread, Log* log);
-
   ~LogBlock() {
     CommonDestructor();

[Ivan Posva, 2015/09/08 21:22:22]

ditto.

Please move to .cc file and remove the unnecessary CommonDestructor().

[koda, 2015/09/09 00:26:57]

Done.

   }