Migrate logging infrastructure Isolate->Thread

runtime/vm/isolate.cc

Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 06dfad2153440b67c04ff43cdeaa55d35a78a82e..60c6326e778ae9486f4a3b2da47a4be7ab74c454 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -907,20 +907,20 @@ void Isolate::BuildName(const char* name_prefix) {
 }
 
 
-Log* Isolate::Log() const {
+bool Isolate::ShouldLog() const {

[Ivan Posva, 2015/09/08 21:22:21]

We might want to move this functionality into the Log class instead.

[koda, 2015/09/09 00:26:57]

Done.

   if (FLAG_isolate_log_filter == NULL) {
     if (is_service_isolate_) {
       // By default, do not log for the service isolate.
-      return Log::NoOpLog();
+      return false;
     }
-    return log_;
+    return true;
   }
   ASSERT(name_ != NULL);
   if (strstr(name_, FLAG_isolate_log_filter) == NULL) {
     // Filter does not match, do not log for this isolate.
-    return Log::NoOpLog();
+    return false;
   }
-  return log_;
+  return true;
 }
 
 
@@ -1565,7 +1565,7 @@ void Isolate::Shutdown() {
                 "\tisolate:    %s\n", name());
     }
     if (FLAG_print_metrics) {
-      LogBlock lb(this);
+      LogBlock lb(thread);
       ISL_Print("Printing metrics for %s\n", name());
 #define ISOLATE_METRIC_PRINT(type, variable, name, unit)                       \
   ISL_Print("%s\n", metric_##variable##_.ToString());