Migrate logging infrastructure Isolate->Thread

runtime/vm/log.cc

Index: runtime/vm/log.cc
diff --git a/runtime/vm/log.cc b/runtime/vm/log.cc
index 5bb984222e94a902b5b44d41fe529e9779589f7d..c8e9e61ddcdbe36172a96da9811d0c5aec1cc99a 100644
--- a/runtime/vm/log.cc
+++ b/runtime/vm/log.cc
@@ -117,24 +117,10 @@ void Log::DisableManualFlush() {
 }
 
 
-LogBlock::LogBlock(Thread* thread, Log* log)
-    : StackResource(thread),
-      log_(log), cursor_(log->cursor()) {
-  CommonConstructor();
-}
-
-
-LogBlock::LogBlock(Isolate* isolate)
-    : StackResource(isolate),
-      log_(isolate->Log()), cursor_(isolate->Log()->cursor()) {
-  CommonConstructor();
-}
-
-
 LogBlock::LogBlock(Thread* thread)
     : StackResource(thread),
-      log_(thread->isolate()->Log()),
-      cursor_(thread->isolate()->Log()->cursor()) {
+      log_(thread->Log()),
+      cursor_(thread->Log()->cursor()) {
   CommonConstructor();

[Ivan Posva, 2015/09/08 21:22:21]

How about changing CommonConstructor() to Initialize(Log*) and use it for both
constructors to also initialize the fields?

[koda, 2015/09/09 00:26:57]

Done (although it prevents the cursor_ field from being declared const).

[Ivan Posva, 2015/09/09 19:56:24]

Actually, I am fine with duplicating the code and having both log_ and cursor_
be const instead.

[koda, 2015/09/09 22:22:57]

Done.

 }