Migrate logging infrastructure Isolate->Thread

runtime/vm/log.h

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_LOG_H_
 #define VM_LOG_H_
 
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
 #include "vm/os.h"
 
 namespace dart {
 
-class Isolate;
 class LogBlock;
 class Thread;
 
+// TODO(koda): Rename ISL_* -> THR_*.

[Ivan Posva, 2015/09/08 21:22:22]

Why not do the rename right now?

[koda, 2015/09/09 00:26:57]

Done.

 #if defined(_MSC_VER)
 #define ISL_Print(format, ...) \
-    Isolate::Current()->Log()->Print(format, __VA_ARGS__)
+    Thread::Current()->Log()->Print(format, __VA_ARGS__)
 #else
 #define ISL_Print(format, ...) \
-    Isolate::Current()->Log()->Print(format, ##__VA_ARGS__)
+    Thread::Current()->Log()->Print(format, ##__VA_ARGS__)
 #endif
 
 #define ISL_VPrint(format, args) \
-    Isolate::Current()->Log()->VPrint(format, args)
+    Thread::Current()->Log()->VPrint(format, args)
 
 typedef void (*LogPrinter)(const char* str, ...);
 
 class Log {
  public:
   explicit Log(LogPrinter printer = OS::Print);
 
   // Append a formatted string to the log.
   void Print(const char* format, ...) PRINTF_ATTRIBUTE(2, 3);
 
@@ skipping 25 matching lines @@
   friend class LogBlock;
   friend class LogTestHelper;
   DISALLOW_COPY_AND_ASSIGN(Log);
 };
 
 
 // Causes all log messages to be buffered until destructor is called.
 // Can be nested.
 class LogBlock : public StackResource {
  public:
-  LogBlock(Isolate* isolate, Log* log)
-      : StackResource(isolate),
+  LogBlock(Thread* thread, Log* log)
+      : StackResource(thread),
         log_(log), cursor_(log->cursor()) {
     CommonConstructor();
   }
 
-  explicit LogBlock(Isolate* isolate);
   explicit LogBlock(Thread* thread);

[Ivan Posva, 2015/09/08 21:22:22]

Is there a particular reason to have this constructor in the .cc file, while the
other is inlined?

[koda, 2015/09/09 00:26:57]

Done.

 
-  LogBlock(Thread* thread, Log* log);
-
   ~LogBlock() {
     CommonDestructor();

[Ivan Posva, 2015/09/08 21:22:22]

ditto.

Please move to .cc file and remove the unnecessary CommonDestructor().

[koda, 2015/09/09 00:26:57]

Done.

   }
 
  private:
   void CommonConstructor() {
     log_->EnableManualFlush();
   }
 
   void CommonDestructor() {
     log_->Flush(cursor_);
     log_->DisableManualFlush();
   }
   Log* log_;
   const intptr_t cursor_;
 };
 
 }  // namespace dart
 
 #endif  // VM_LOG_H_