remoting/host/setup/start_host.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/setup/start_host.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/setup/start_host.cc

diff --git a/remoting/host/setup/start_host.cc b/remoting/host/setup/start_host.cc

index 4d8ba75cfb5abefd17f057052520dcfd0f64b47f..256fb3cfb967cefbd3b187164553b2c1243abd82 100644

--- a/remoting/host/setup/start_host.cc

+++ b/remoting/host/setup/start_host.cc

@@ -53,7 +53,7 @@ std::string ReadString(bool no_echo) {

SetEcho(true);

}

if (!result)

- return "";

+ return std::string();

size_t newline_index = str.find('\n');

if (newline_index != std::string::npos)

str[newline_index] = '\0';