base/nix/mime_util_xdg.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/nix/mime_util_xdg.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/nix/mime_util_xdg.cc

diff --git a/base/nix/mime_util_xdg.cc b/base/nix/mime_util_xdg.cc

index 00dcafad45174b71089dcc68c6a3c3b076375960..458245c3d110b38c4f45459b6139a9ae8ebd3657 100644

--- a/base/nix/mime_util_xdg.cc

+++ b/base/nix/mime_util_xdg.cc

@@ -344,9 +344,9 @@ size_t IconTheme::MatchesSize(SubDirInfo* info, size_t size) {

std::string IconTheme::ReadLine(FILE* fp) {

if (!fp)

- return "";

+ return std::string();

- std::string result = "";

+ std::string result = std::string();

darin (slow to review) 2013/04/09 05:27:57 nit: another one

const size_t kBufferSize = 100;

char buffer[kBufferSize];

while ((fgets(buffer, kBufferSize - 1, fp)) != NULL) {