Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: remoting/host/setup/oauth_helper.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/setup/oauth_helper.cc
diff --git a/remoting/host/setup/oauth_helper.cc b/remoting/host/setup/oauth_helper.cc
index 6f110f6c2214af2ec5aa37dbc02c80252b462501..6ea46d5e5db38d74f7c4cd36a8b62b461ae498d7 100644
--- a/remoting/host/setup/oauth_helper.cc
+++ b/remoting/host/setup/oauth_helper.cc
@@ -14,7 +14,7 @@ namespace {
std::string GetComponent(const std::string& url,
const url_parse::Component component) {
if (component.len < 0) {
- return "";
+ return std::string();
}
return url.substr(component.begin, component.len);
}
@@ -60,11 +60,11 @@ std::string GetOauthCodeInUrl(const std::string& url,
&redirect_url_parsed);
if (GetComponent(url, url_parsed.scheme) !=
GetComponent(redirect_url, redirect_url_parsed.scheme)) {
- return "";
+ return std::string();
}
if (GetComponent(url, url_parsed.host) !=
GetComponent(redirect_url, redirect_url_parsed.host)) {
- return "";
+ return std::string();
}
url_parse::Component query = url_parsed.query;
url_parse::Component key;
@@ -74,7 +74,7 @@ std::string GetOauthCodeInUrl(const std::string& url,
return GetComponent(url, value);
}
}
- return "";
+ return std::string();
}
} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698