Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: remoting/jingle_glue/iq_sender_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/jingle_glue/iq_sender_unittest.cc
diff --git a/remoting/jingle_glue/iq_sender_unittest.cc b/remoting/jingle_glue/iq_sender_unittest.cc
index b09f114d3fee09047b63540a992b615352b0faac..287673573cba6aa75f1eb2fad9579da542fa5b75 100644
--- a/remoting/jingle_glue/iq_sender_unittest.cc
+++ b/remoting/jingle_glue/iq_sender_unittest.cc
@@ -91,9 +91,9 @@ TEST_F(IqSenderTest, SendIq) {
});
scoped_ptr<XmlElement> response(new XmlElement(buzz::QN_IQ));
- response->AddAttr(QName("", "type"), "result");
- response->AddAttr(QName("", "id"), kStanzaId);
- response->AddAttr(QName("", "from"), kTo);
+ response->AddAttr(QName(std::string(), "type"), "result");
+ response->AddAttr(QName(std::string(), "id"), kStanzaId);
+ response->AddAttr(QName(std::string(), "from"), kTo);
XmlElement* result = new XmlElement(
QName("test:namespace", "response-body"));
@@ -123,9 +123,9 @@ TEST_F(IqSenderTest, InvalidFrom) {
});
scoped_ptr<XmlElement> response(new XmlElement(buzz::QN_IQ));
- response->AddAttr(QName("", "type"), "result");
- response->AddAttr(QName("", "id"), kStanzaId);
- response->AddAttr(QName("", "from"), "different_user@domain.com");
+ response->AddAttr(QName(std::string(), "type"), "result");
+ response->AddAttr(QName(std::string(), "id"), kStanzaId);
+ response->AddAttr(QName(std::string(), "from"), "different_user@domain.com");
XmlElement* result = new XmlElement(
QName("test:namespace", "response-body"));
@@ -143,9 +143,9 @@ TEST_F(IqSenderTest, IdMatchingHack) {
});
scoped_ptr<XmlElement> response(new XmlElement(buzz::QN_IQ));
- response->AddAttr(QName("", "type"), "result");
- response->AddAttr(QName("", "id"), "DIFFERENT_ID");
- response->AddAttr(QName("", "from"), kTo);
+ response->AddAttr(QName(std::string(), "type"), "result");
+ response->AddAttr(QName(std::string(), "id"), "DIFFERENT_ID");
+ response->AddAttr(QName(std::string(), "from"), kTo);
XmlElement* result = new XmlElement(
QName("test:namespace", "response-body"));

Powered by Google App Engine
This is Rietveld 408576698