base/prefs/pref_service_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_service_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/prefs/pref_service_unittest.cc

diff --git a/base/prefs/pref_service_unittest.cc b/base/prefs/pref_service_unittest.cc

index 26fe19a8699d7f41e9848f004f303cab5a4609ae..927f2f7779f8cf7869301a2ee51731e6b6c9b816 100644

--- a/base/prefs/pref_service_unittest.cc

+++ b/base/prefs/pref_service_unittest.cc

@@ -45,7 +45,7 @@ TEST(PrefServiceTest, NoObserverFire) {

Mock::VerifyAndClearExpectations(&obs);

// Clearing the pref should cause the pref to fire.

- const StringValue expected_default_value("");

+ const StringValue expected_default_value((std::string()));

obs.Expect(pref_name, &expected_default_value);

prefs.ClearPref(pref_name);

Mock::VerifyAndClearExpectations(&obs);