base/prefs/pref_change_registrar_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_change_registrar_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/prefs/pref_change_registrar_unittest.cc

diff --git a/base/prefs/pref_change_registrar_unittest.cc b/base/prefs/pref_change_registrar_unittest.cc

index 49da72128b0d686cce8be4bb68c1378c29af16b7..f353a8fb3c57cb5c6a823749f776db96279d6a7e 100644

--- a/base/prefs/pref_change_registrar_unittest.cc

+++ b/base/prefs/pref_change_registrar_unittest.cc

@@ -132,7 +132,7 @@ class ObserveSetOfPreferencesTest : public testing::Test {

PrefRegistrySimple* registry = pref_service_->registry();

registry->RegisterStringPref(kHomePage, "http://google.com");

registry->RegisterBooleanPref(kHomePageIsNewTabPage, false);

- registry->RegisterStringPref(kApplicationLocale, "");

+ registry->RegisterStringPref(kApplicationLocale, std::string());

}

PrefChangeRegistrar* CreatePrefChangeRegistrar() {